net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout'

deokjinkim · targos · commit 40a7b0b993f0 · 2023-03-14T07:54:11.000+01:00
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: #47012 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/doc/api/net.md b/doc/api/net.md
@@ -1659,7 +1659,7 @@ added: REPLACEME
 Sets the default value of the `autoSelectFamilyAttemptTimeout` option of [`socket.connect(options)`][].
 
 * `value` {number} The new default value, which must be a positive number. If the number is less than `10`,
-  the value `10` is used insted The initial default value is `250`.
+  the value `10` is used instead. The initial default value is `250`.
 
 ## `net.isIP(input)`
 
diff --git a/lib/net.js b/lib/net.js
@@ -247,7 +247,7 @@ function getDefaultAutoSelectFamilyAttemptTimeout() {
 function setDefaultAutoSelectFamilyAttemptTimeout(value) {
   validateInt32(value, 'value', 1);
 
-  if (value < 1) {
+  if (value < 10) {
     value = 10;
   }
 
diff --git a/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js b/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js
@@ -18,3 +18,10 @@ for (const autoSelectFamilyAttemptTimeout of [-10, 0]) {
     net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout);
   }, { code: 'ERR_OUT_OF_RANGE' });
 }
+
+// Check the default value of autoSelectFamilyAttemptTimeout is 10
+// if passed number is less than 10
+for (const autoSelectFamilyAttemptTimeout of [1, 9]) {
+  net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout);
+  assert.strictEqual(net.getDefaultAutoSelectFamilyAttemptTimeout(), 10);
+}

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ function getDefaultAutoSelectFamilyAttemptTimeout() {`
`247`	`247`	`function setDefaultAutoSelectFamilyAttemptTimeout(value) {`
`248`	`248`	`validateInt32(value, 'value', 1);`
`249`	`249`
`250`		`- if (value < 1) {`
	`250`	`+ if (value < 10) {`
`251`	`251`	`value = 10;`
`252`	`252`	`}`
`253`	`253`