Skip to content

Commit 3e8eb44

Browse files
legendecasaduh95
authored andcommitted
doc: add doc on when to backport V8 patches to main
Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #66710 Refs: #66393 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 0f93f4a commit 3e8eb44

1 file changed

Lines changed: 22 additions & 0 deletions

File tree

‎doc/contributing/maintaining/maintaining-V8.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,28 @@ fixed upstream first.
7777
branches that are still active or are branches that Node.js cares about.
7878
Follow the process for backporting below.
7979

80+
### Backporting patches to `main`
81+
82+
As a general rule, do not backport individual V8 patches to the Node.js `main`
83+
branch. Wait for them to be included in a V8 major version update instead.
84+
An individual V8 patch adds up audit cost and further delays the pending V8
85+
update.
86+
87+
A patch may be backported to `main` when at least one of these criteria applies:
88+
89+
* It fixes a build issue on a platform or toolchain supported on `main`.
90+
* It fixes a security issue.
91+
* It unblocks a pending V8 update, for example by adjusting how the Node.js code
92+
uses a V8 API so that it works with the future update.
93+
94+
If the patch meet the following criteria, it's recommended to backport the patches
95+
to the release staging branches like `v<MAJOR>.x-staging` (see
96+
[Criteria for backporting](../backporting-to-release-lines.md#criteria-for-backporting)
97+
to decide what release line to target), instead of `main`:
98+
99+
* It has demonstrated real-world urgency and impact that justifies landing it
100+
before the next V8 major version update.
101+
80102
### Backporting to active branches
81103

82104
If the bug exists in any of the active V8 branches, we may need to get the fix

0 commit comments

Comments
 (0)