process: make execve's args argument optional

mureinik · aduh95 · commit 3d2f919f7c47 · 2025-07-27T23:52:43.000+02:00
Align the code with the documentation and similar methods used to execute os commands - the `args` argument should be optional, and if omitted, treated as an empty array (`[]`). Fixes: #58411 PR-URL: #58412 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <richard.lau@ibm.com>
diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -279,7 +279,7 @@ function wrapProcessMethods(binding) {
     return true;
   }
 
-  function execve(execPath, args, env) {
+  function execve(execPath, args = [], env) {
     emitExperimentalWarning('process.execve');
 
     const { isMainThread } = require('internal/worker');
diff --git a/node.gyp b/node.gyp
@@ -1336,6 +1336,13 @@
         }],
       ]
     }, # overlapped-checker
+    {
+      'target_name': 'nop',
+      'type': 'executable',
+      'sources': [
+        'test/nop/nop.c',
+      ]
+    }, # nop
     {
       'target_name': 'node_js2c',
       'type': 'executable',
diff --git a/test/nop/nop.c b/test/nop/nop.c
@@ -0,0 +1,3 @@
+int main(void) {
+  return 0;
+}
diff --git a/test/parallel/test-process-execve-no-args.js b/test/parallel/test-process-execve-no-args.js
@@ -0,0 +1,25 @@
+'use strict';
+
+const { skip, isWindows, isIBMi } = require('../common');
+const { fail } = require('assert');
+const { isMainThread } = require('worker_threads');
+const { dirname, join } = require('path');
+const { existsSync } = require('fs');
+
+if (!isMainThread) {
+  skip('process.execve is not available in Workers');
+} else if (isWindows || isIBMi) {
+  skip('process.execve is not available in Windows or IBM i');
+}
+
+// Get full path to the executable used for the test
+const executable = join(dirname(process.execPath), 'nop');
+
+// Sanity check that the binary exists
+if (!existsSync(executable)) {
+  skip(executable + ' binary is not available');
+}
+
+process.execve(executable);
+// If process.execve succeeds, this should never be executed.
+fail('process.execve failed');

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ function wrapProcessMethods(binding) {`
`279`	`279`	`return true;`
`280`	`280`	`}`
`281`	`281`
`282`		`- function execve(execPath, args, env) {`
	`282`	`+ function execve(execPath, args = [], env) {`
`283`	`283`	`emitExperimentalWarning('process.execve');`
`284`	`284`
`285`	`285`	`const { isMainThread } = require('internal/worker');`
Original file line number	Diff line number	Diff line change
`@@ -1336,6 +1336,13 @@`
`1336`	`1336`	`}],`
`1337`	`1337`	`]`
`1338`	`1338`	`}, # overlapped-checker`
	`1339`	`+ {`
	`1340`	`+ 'target_name': 'nop',`
	`1341`	`+ 'type': 'executable',`
	`1342`	`+ 'sources': [`
	`1343`	`+ 'test/nop/nop.c',`
	`1344`	`+ ]`
	`1345`	`+ }, # nop`
`1339`	`1346`	`{`
`1340`	`1347`	`'target_name': 'node_js2c',`
`1341`	`1348`	`'type': 'executable',`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+int main(void) {`
	`2`	`+ return 0;`
	`3`	`+}`