Skip to content

Commit 3b9e2be

Browse files
committed
fixup: update error message
1 parent c3672b0 commit 3b9e2be

4 files changed

Lines changed: 21 additions & 23 deletions

test/parallel/test-stringbytes-external-at-max.js

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,25 @@ require('../common');
44
const assert = require('assert');
55

66
// v8 fails silently if string length > v8::String::kMaxLength
7-
(function() {
8-
// v8::String::kMaxLength defined in v8.h
9-
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
7+
// v8::String::kMaxLength defined in v8.h
8+
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
109

11-
try {
12-
new Buffer(kStringMaxLength * 3);
13-
} catch(e) {
14-
assert.equal(e.message, 'Invalid array buffer length');
15-
console.log(
16-
'1..0 # Skipped: intensive toString tests due to memory confinements');
17-
return;
18-
}
10+
try {
11+
new Buffer(kStringMaxLength * 3);
12+
} catch(e) {
13+
assert.equal(e.message, 'Invalid typed array length');
14+
console.log(
15+
'1..0 # Skipped: intensive toString tests due to memory confinements');
16+
return;
17+
}
1918

20-
const buf = new Buffer(kStringMaxLength);
19+
const buf = new Buffer(kStringMaxLength);
2120

22-
var maxString = buf.toString();
23-
assert.equal(maxString.length, kStringMaxLength);
24-
// Free the memory early instead of at the end of the next assignment
25-
maxString = undefined;
21+
var maxString = buf.toString();
22+
assert.equal(maxString.length, kStringMaxLength);
23+
// Free the memory early instead of at the end of the next assignment
24+
maxString = undefined;
2625

27-
maxString = buf.toString('binary');
28-
assert.equal(maxString.length, kStringMaxLength);
29-
maxString = undefined;
30-
})();
26+
maxString = buf.toString('binary');
27+
assert.equal(maxString.length, kStringMaxLength);
28+
maxString = undefined;

test/parallel/test-stringbytes-external-exceed-max-by-1.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const kStringMaxLength = process.binding('buffer').kStringMaxLength;
1010
try {
1111
new Buffer(kStringMaxLength * 3);
1212
} catch(e) {
13-
assert.equal(e.message, 'Invalid array buffer length');
13+
assert.equal(e.message, 'Invalid typed array length');
1414
console.log(
1515
'1..0 # Skipped: intensive toString tests due to memory confinements');
1616
return;

test/parallel/test-stringbytes-external-exceed-max-by-2.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const kStringMaxLength = process.binding('buffer').kStringMaxLength;
1010
try {
1111
new Buffer(kStringMaxLength * 3);
1212
} catch(e) {
13-
assert.equal(e.message, 'Invalid array buffer length');
13+
assert.equal(e.message, 'Invalid typed array length');
1414
console.log(
1515
'1..0 # Skipped: intensive toString tests due to memory confinements');
1616
return;

test/parallel/test-stringbytes-external-exceed-max.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const kStringMaxLength = process.binding('buffer').kStringMaxLength;
1010
try {
1111
new Buffer(kStringMaxLength * 3);
1212
} catch(e) {
13-
assert.equal(e.message, 'Invalid array buffer length');
13+
assert.equal(e.message, 'Invalid typed array length');
1414
console.log(
1515
'1..0 # Skipped: intensive toString tests due to memory confinements');
1616
return;

0 commit comments

Comments
 (0)