repl: fix bug in fs module autocompletion

zhangyongsheng · zhangyongsheng · commit 2f497a67ad87 · 2019-09-18T09:58:59.000+08:00
PR-URL: #29555 Fixes: #29424 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/repl.js b/lib/repl.js
@@ -1193,7 +1193,7 @@ function complete(line, callback) {
           d.name.startsWith(baseName))
           .map((d) => d.name);
         completionGroups.push(filteredValue);
-        completeOn = filePath;
+        completeOn = baseName;
       } catch {}
     }
 
diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
@@ -28,6 +28,7 @@ const {
   restoreStderr
 } = require('../common/hijackstdio');
 const assert = require('assert');
+const path = require('path');
 const fixtures = require('../common/fixtures');
 const hasInspector = process.features.inspector;
 
@@ -434,6 +435,16 @@ testMe.complete('obj.', common.mustCall((error, data) => {
                         assert.strictEqual(data[0].length, 0);
                       })
       );
+
+      const testPath = fixturePath.slice(0, -1);
+      testMe.complete(testPath, common.mustCall((err, data) => {
+        assert.strictEqual(err, null);
+        assert.ok(data[0][0].includes('test-repl-tab-completion'));
+        assert.strictEqual(
+          data[1],
+          path.basename(testPath)
+        );
+      }));
     });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1193,7 +1193,7 @@ function complete(line, callback) {`
`1193`	`1193`	`d.name.startsWith(baseName))`
`1194`	`1194`	`.map((d) => d.name);`
`1195`	`1195`	`completionGroups.push(filteredValue);`
`1196`		`- completeOn = filePath;`
	`1196`	`+ completeOn = baseName;`
`1197`	`1197`	`} catch {}`
`1198`	`1198`	`}`
`1199`	`1199`