v8: fix missing callback in heap utils destroy

BridgeAR · targos · commit 2b34867ba919 · 2025-07-03T10:52:36.000+02:00
This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place. PR-URL: #58846 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
diff --git a/lib/internal/heap_utils.js b/lib/internal/heap_utils.js
@@ -53,11 +53,12 @@ class HeapSnapshotStream extends Readable {
       this[kHandle].readStart();
   }
 
-  _destroy() {
+  _destroy(err, callback) {
     // Release the references on the handle so that
     // it can be garbage collected.
     this[kHandle][owner_symbol] = undefined;
     this[kHandle] = undefined;
+    callback(err);
   }
 
   [kUpdateTimer]() {
diff --git a/test/sequential/test-heapdump.js b/test/sequential/test-heapdump.js
@@ -10,6 +10,7 @@ if (!isMainThread) {
 const { writeHeapSnapshot, getHeapSnapshot } = require('v8');
 const assert = require('assert');
 const fs = require('fs');
+const { promises: { pipeline }, PassThrough } = require('stream');
 const tmpdir = require('../common/tmpdir');
 
 tmpdir.refresh();
@@ -78,3 +79,13 @@ process.chdir(tmpdir.path);
     JSON.parse(data);
   }));
 }
+
+{
+  const passthrough = new PassThrough();
+  passthrough.on('data', common.mustCallAtLeast(1));
+
+  pipeline(
+    getHeapSnapshot(),
+    passthrough,
+  ).then(common.mustCall());
+}

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,12 @@ class HeapSnapshotStream extends Readable {`
`53`	`53`	`this[kHandle].readStart();`
`54`	`54`	`}`
`55`	`55`
`56`		`- _destroy() {`
	`56`	`+ _destroy(err, callback) {`
`57`	`57`	`// Release the references on the handle so that`
`58`	`58`	`// it can be garbage collected.`
`59`	`59`	`this[kHandle][owner_symbol] = undefined;`
`60`	`60`	`this[kHandle] = undefined;`
	`61`	`+ callback(err);`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`[kUpdateTimer]() {`