child_process: add nullptr checks after allocs

addaleax · addaleax · commit 29ca96965119 · 2016-04-20T18:03:54.000+02:00
Add `CHECK_NE(·, nullptr)` after allocations made when spawning child processes. PR-URL: #6256 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/process_wrap.cc b/src/process_wrap.cc
@@ -166,6 +166,7 @@ class ProcessWrap : public HandleWrap {
       for (int i = 0; i < argc; i++) {
         node::Utf8Value arg(env->isolate(), js_argv->Get(i));
         options.args[i] = strdup(*arg);
+        CHECK_NE(options.args[i], nullptr);
       }
       options.args[argc] = nullptr;
     }
@@ -187,6 +188,7 @@ class ProcessWrap : public HandleWrap {
       for (int i = 0; i < envc; i++) {
         node::Utf8Value pair(env->isolate(), env_opt->Get(i));
         options.env[i] = strdup(*pair);
+        CHECK_NE(options.env[i], nullptr);
       }
       options.env[envc] = nullptr;
     }

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ class ProcessWrap : public HandleWrap {`
`166`	`166`	`for (int i = 0; i < argc; i++) {`
`167`	`167`	`node::Utf8Value arg(env->isolate(), js_argv->Get(i));`
`168`	`168`	`options.args[i] = strdup(*arg);`
	`169`	`+ CHECK_NE(options.args[i], nullptr);`
`169`	`170`	`}`
`170`	`171`	`options.args[argc] = nullptr;`
`171`	`172`	`}`
`@@ -187,6 +188,7 @@ class ProcessWrap : public HandleWrap {`
`187`	`188`	`for (int i = 0; i < envc; i++) {`
`188`	`189`	`node::Utf8Value pair(env->isolate(), env_opt->Get(i));`
`189`	`190`	`options.env[i] = strdup(*pair);`
	`191`	`+ CHECK_NE(options.env[i], nullptr);`
`190`	`192`	`}`
`191`	`193`	`options.env[envc] = nullptr;`
`192`	`194`	`}`