child_process: emit IPC messages on next tick

cjihrig · rvagg · commit 27d0eb054ce1 · 2016-06-02T22:39:20.000+10:00
Currently, if an IPC event handler throws an error, it can cause the message to not be consumed, leading to messages piling up. This commit causes IPC events to be emitted on the next tick, allowing the channel's processing logic to move forward as normal. Fixes: #6561 PR-URL: #6909 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -715,7 +715,9 @@ function handleMessage(target, message, handle) {
       message.cmd.slice(0, INTERNAL_PREFIX.length) === INTERNAL_PREFIX) {
     eventName = 'internalMessage';
   }
-  target.emit(eventName, message, handle);
+  process.nextTick(() => {
+    target.emit(eventName, message, handle);
+  });
 }
 
 function nop() { }

Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,9 @@ function handleMessage(target, message, handle) {`
`715`	`715`	`message.cmd.slice(0, INTERNAL_PREFIX.length) === INTERNAL_PREFIX) {`
`716`	`716`	`eventName = 'internalMessage';`
`717`	`717`	`}`
`718`		`- target.emit(eventName, message, handle);`
	`718`	`+ process.nextTick(() => {`
	`719`	`+ target.emit(eventName, message, handle);`
	`720`	`+ });`
`719`	`721`	`}`
`720`	`722`
`721`	`723`	`function nop() { }`