test: use countdown timer

daxlab · MylesBorins · commit 27107b957c19 · 2018-02-27T01:12:16.000-05:00
PR-URL: #17326 Refs: #17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/parallel/test-http-response-status-message.js b/test/parallel/test-http-response-status-message.js
@@ -3,8 +3,7 @@ require('../common');
 const assert = require('assert');
 const http = require('http');
 const net = require('net');
-
-let testsComplete = 0;
+const Countdown = require('../common/countdown');
 
 const testCases = [
   { path: '/200', statusMessage: 'OK',
@@ -38,6 +37,8 @@ const server = net.createServer(function(connection) {
   });
 });
 
+const countdown = new Countdown(testCases.length, () => server.close());
+
 function runTest(testCaseIndex) {
   const testCase = testCases[testCaseIndex];
 
@@ -50,12 +51,9 @@ function runTest(testCaseIndex) {
     assert.strictEqual(testCase.statusMessage, response.statusMessage);
 
     response.on('end', function() {
-      testsComplete++;
-
+      countdown.dec();
       if (testCaseIndex + 1 < testCases.length) {
         runTest(testCaseIndex + 1);
-      } else {
-        server.close();
       }
     });
 
@@ -64,7 +62,3 @@ function runTest(testCaseIndex) {
 }
 
 server.listen(0, function() { runTest(0); });
-
-process.on('exit', function() {
-  assert.strictEqual(testCases.length, testsComplete);
-});
