Skip to content

Commit 2030fd3

Browse files
Hardanish-SinghHardanish-Singh
authored
doc: fix typos and grammar in BUILDING.md & onboarding.md
PR-URL: #61267 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent d050aa8 commit 2030fd3

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎BUILDING.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/)
635635
(using an image like `gengjiawen/node-build:2020-02-14`).
636636

637637
The `--debug` is not necessary and will slow down build and testing, but it can
638-
show clear stacktrace if ASan hits an issue.
638+
show a clear stack trace if ASan hits an issue.
639639

640640
```bash
641641
./configure --debug --enable-asan && make -j4
@@ -713,8 +713,8 @@ the number of parallel build tasks (`-j<n>`).
713713

714714
#### Tips
715715

716-
You may need disable vcpkg integration if you got link error about symbol
717-
redefine related to zlib.lib(zlib1.dll), even you never install it by hand,
716+
You may need to disable vcpkg integration if you encounter a link error about symbol
717+
redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand,
718718
as vcpkg is part of CLion and Visual Studio now.
719719

720720
```powershell
@@ -889,7 +889,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe
889889
```
890890

891891
With newer version of Visual Studio, it may need the copy to be `clang-cl.exe`
892-
instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy
892+
instead. If the output of `vcbuild.bat` suggests missing `clang-cl.exe`, copy
893893
it differently:
894894

895895
```powershell
@@ -1052,7 +1052,7 @@ configure option:
10521052
## Building Node.js with Temporal support
10531053

10541054
Node.js supports the [Temporal](https://github.com/tc39/proposal-temporal) APIs, when
1055-
linking statically or dynamically with a version [temporal\_rs](https://github.com/boa-dev/temporal).
1055+
linking statically or dynamically with a version of [temporal\_rs](https://github.com/boa-dev/temporal).
10561056

10571057
To build Node.js with Temporal support, a Rust toolchain is required:
10581058

‎onboarding.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding.
286286
* If you are interested in helping to fix coverity reports consider requesting
287287
access to the projects coverity project as outlined in [static-analysis][].
288288
* If you are interested in helping out with CI reliability, check out the
289-
[reliability respository][] and [guide on how to deal with CI flakes][].
289+
[reliability repository][] and [guide on how to deal with CI flakes][].
290290

291291
[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
292292
[Labels]: doc/contributing/collaborator-guide.md#labels
@@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding.
299299
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/
300300
[guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability
301301
[participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules
302-
[reliability respository]: https://github.com/nodejs/reliability
302+
[reliability repository]: https://github.com/nodejs/reliability
303303
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-github-credentials
304304
[static-analysis]: doc/contributing/static-analysis.md
305305
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/

0 commit comments

Comments
 (0)