Revert "Revert "repl: disable Ctrl+C support..."

MylesBorins · MylesBorins · commit 1978911c7587 · 2017-03-28T04:51:56.000-04:00
Full original message: Revert "repl: disable Ctrl+C support on win32 for now" This reverts commit 1d400ea.
diff --git a/lib/repl.js b/lib/repl.js
@@ -322,7 +322,13 @@ function REPLServer(prompt,
     if (!err) {
       // Unset raw mode during evaluation so that Ctrl+C raises a signal.
       let previouslyInRawMode;
-      if (self.breakEvalOnSigint) {
+
+      // Temporarily disabled on Windows due to output problems that likely
+      // result from the raw mode switches here, see
+      // https://github.com/nodejs/node/issues/7837
+      // Setting NODE_REPL_CTRLC is meant as a temporary opt-in for debugging.
+      if (self.breakEvalOnSigint &&
+          (process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
         // Start the SIGINT watchdog before entering raw mode so that a very
         // quick Ctrl+C doesn’t lead to aborting the process completely.
         utilBinding.startSigintWatchdog();
@@ -342,7 +348,8 @@ function REPLServer(prompt,
             result = script.runInContext(context, scriptOptions);
           }
         } finally {
-          if (self.breakEvalOnSigint) {
+          if (self.breakEvalOnSigint &&
+              (process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
             // Reset terminal mode to its previous value.
             self._setRawMode(previouslyInRawMode);
 
