src: fix query/fragment serialization in URL::SerializeURL

addaleax · danielleadams · commit 170a6cb33e89 · 2022-04-23T22:25:57.000-04:00
These are presumably typos. PR-URL: #41759 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -1576,10 +1576,10 @@ std::string URL::SerializeURL(const struct url_data* url,
     }
   }
   if (url->flags & URL_FLAGS_HAS_QUERY) {
-    output = "?" + url->query;
+    output += "?" + url->query;
   }
   if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {
-    output = "#" + url->fragment;
+    output += "#" + url->fragment;
   }
   return output;
 }

Original file line number	Diff line number	Diff line change
`@@ -1576,10 +1576,10 @@ std::string URL::SerializeURL(const struct url_data* url,`
`1576`	`1576`	`}`
`1577`	`1577`	`}`
`1578`	`1578`	`if (url->flags & URL_FLAGS_HAS_QUERY) {`
`1579`		`- output = "?" + url->query;`
	`1579`	`+ output += "?" + url->query;`
`1580`	`1580`	`}`
`1581`	`1581`	`if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {`
`1582`		`- output = "#" + url->fragment;`
	`1582`	`+ output += "#" + url->fragment;`
`1583`	`1583`	`}`
`1584`	`1584`	`return output;`
`1585`	`1585`	`}`