stream: check for null instead of falsy in loops

Trott · BethGriggs · commit 16dec4268cd7 · 2022-01-24T17:35:58.000Z
Check for null in while loops. This is preparing the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/internal/streams/buffer_list.js b/lib/internal/streams/buffer_list.js
@@ -57,7 +57,7 @@ module.exports = class BufferList {
       return '';
     let p = this.head;
     let ret = '' + p.data;
-    while (p = p.next)
+    while ((p = p.next) !== null)
       ret += s + p.data;
     return ret;
   }
@@ -129,7 +129,7 @@ module.exports = class BufferList {
         break;
       }
       ++c;
-    } while (p = p.next);
+    } while ((p = p.next) !== null);
     this.length -= c;
     return ret;
   }
@@ -163,7 +163,7 @@ module.exports = class BufferList {
         break;
       }
       ++c;
-    } while (p = p.next);
+    } while ((p = p.next) !== null);
     this.length -= c;
     return ret;
   }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ module.exports = class BufferList {`
`57`	`57`	`return '';`
`58`	`58`	`let p = this.head;`
`59`	`59`	`let ret = '' + p.data;`
`60`		`- while (p = p.next)`
	`60`	`+ while ((p = p.next) !== null)`
`61`	`61`	`ret += s + p.data;`
`62`	`62`	`return ret;`
`63`	`63`	`}`
`@@ -129,7 +129,7 @@ module.exports = class BufferList {`
`129`	`129`	`break;`
`130`	`130`	`}`
`131`	`131`	`++c;`
`132`		`- } while (p = p.next);`
	`132`	`+ } while ((p = p.next) !== null);`
`133`	`133`	`this.length -= c;`
`134`	`134`	`return ret;`
`135`	`135`	`}`
`@@ -163,7 +163,7 @@ module.exports = class BufferList {`
`163`	`163`	`break;`
`164`	`164`	`}`
`165`	`165`	`++c;`
`166`		`- } while (p = p.next);`
	`166`	`+ } while ((p = p.next) !== null);`
`167`	`167`	`this.length -= c;`
`168`	`168`	`return ret;`
`169`	`169`	`}`