test: favor assertions over console logging

Trott · jasnell · commit 12de99d982c8 · 2017-02-27T12:13:36.000-08:00
Communicate about leaked globals via `AssertionError` rather than `console.log()`. PR-URL: #11547 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/common.js b/test/common.js
@@ -402,8 +402,7 @@ process.on('exit', function() {
   if (!exports.globalCheck) return;
   const leaked = leakedGlobals();
   if (leaked.length > 0) {
-    console.error('Unknown globals: %s', leaked);
-    fail('Unknown global found');
+    fail(`Unexpected global(s) found: ${leaked.join(', ')}`);
   }
 });
 

Original file line number	Diff line number	Diff line change
`@@ -402,8 +402,7 @@ process.on('exit', function() {`
`402`	`402`	`if (!exports.globalCheck) return;`
`403`	`403`	`const leaked = leakedGlobals();`
`404`	`404`	`if (leaked.length > 0) {`
`405`		`- console.error('Unknown globals: %s', leaked);`
`406`		`- fail('Unknown global found');`
	`405`	+ fail(`Unexpected global(s) found: ${leaked.join(', ')}`);
`407`	`406`	`}`
`408`	`407`	`});`
`409`	`408`