Skip to content

Commit 0f33bb0

Browse files
aduh95danielleadams
aduh95
authored and
danielleadams
committed
lib: add trailing commas to all public core modules
PR-URL: #46848 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
1 parent 17fbfb2 commit 0f33bb0

30 files changed

+214
-245
lines changed

‎lib/.eslintrc.yaml‎

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -252,58 +252,27 @@ globals:
252252
overrides:
253253
- files:
254254
- ./*/*.js
255-
- ./_*.js
256-
- ./child_process.js
257-
- ./cluster.js
258-
- ./console.js
259-
- ./constants.js
260-
- ./events.js
261-
- ./fs.js
262-
- ./internal/assert.js
263-
- ./internal/child_process.js
255+
- ./*.js
264256
- ./internal/child_process/*.js
265-
- ./internal/cli_table.js
266257
- ./internal/cluster/*.js
267258
- ./internal/debugger/*.js
268-
- ./internal/event_target.js
269259
- ./internal/events/*.js
270-
- ./internal/fixed_queue.js
271-
- ./internal/freelist.js
272260
- ./internal/fs/*.js
273-
- ./internal/heap_utils.js
274-
- ./internal/http.js
275-
- ./internal/idna.js
276-
- ./internal/js_stream_socket.js
277-
- ./internal/mime.js
278261
- ./internal/modules/*.js
279262
- ./internal/per_context/*.js
280263
- ./internal/perf/*.js
281264
- ./internal/policy/*.js
282-
- ./internal/priority_queue.js
283265
- ./internal/process/*.js
284266
- ./internal/readline/*.js
285267
- ./internal/readme.md
286-
- ./internal/repl.js
287268
- ./internal/repl/*.js
288269
- ./internal/source_map/*.js
289270
- ./internal/streams/*.js
290-
- ./internal/structured_clone.js
291271
- ./internal/test/*.js
292272
- ./internal/test_runner/**/*.js
293273
- ./internal/tls/*.js
294274
- ./internal/util/parse_args/*.js
295-
- ./internal/v8_prof_processor.js
296-
- ./internal/vm.js
297275
- ./internal/watch_mode/*.js
298-
- ./internal/webidl.js
299276
- ./internal/webstreams/*.js
300-
- ./module.js
301-
- ./process.js
302-
- ./punycode.js
303-
- ./repl.js
304-
- ./sys.js
305-
- ./test.js
306-
- ./tls.js
307-
- ./url.js
308277
rules:
309278
comma-dangle: [error, always-multiline]

‎lib/assert.js‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function fail(actual, expected, message, operator, stackStartFn) {
163163
expected,
164164
operator: operator === undefined ? 'fail' : operator,
165165
stackStartFn: stackStartFn || fail,
166-
message
166+
message,
167167
};
168168
const err = new AssertionError(errArgs);
169169
if (internalMessage) {
@@ -393,7 +393,7 @@ function innerOk(fn, argLen, value, message) {
393393
expected: true,
394394
message,
395395
operator: '==',
396-
stackStartFn: fn
396+
stackStartFn: fn,
397397
});
398398
err.generatedMessage = generatedMessage;
399399
throw err;
@@ -430,7 +430,7 @@ assert.equal = function equal(actual, expected, message) {
430430
expected,
431431
message,
432432
operator: '==',
433-
stackStartFn: equal
433+
stackStartFn: equal,
434434
});
435435
}
436436
};
@@ -454,7 +454,7 @@ assert.notEqual = function notEqual(actual, expected, message) {
454454
expected,
455455
message,
456456
operator: '!=',
457-
stackStartFn: notEqual
457+
stackStartFn: notEqual,
458458
});
459459
}
460460
};
@@ -477,7 +477,7 @@ assert.deepEqual = function deepEqual(actual, expected, message) {
477477
expected,
478478
message,
479479
operator: 'deepEqual',
480-
stackStartFn: deepEqual
480+
stackStartFn: deepEqual,
481481
});
482482
}
483483
};
@@ -500,7 +500,7 @@ assert.notDeepEqual = function notDeepEqual(actual, expected, message) {
500500
expected,
501501
message,
502502
operator: 'notDeepEqual',
503-
stackStartFn: notDeepEqual
503+
stackStartFn: notDeepEqual,
504504
});
505505
}
506506
};
@@ -525,7 +525,7 @@ assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
525525
expected,
526526
message,
527527
operator: 'deepStrictEqual',
528-
stackStartFn: deepStrictEqual
528+
stackStartFn: deepStrictEqual,
529529
});
530530
}
531531
};
@@ -550,7 +550,7 @@ function notDeepStrictEqual(actual, expected, message) {
550550
expected,
551551
message,
552552
operator: 'notDeepStrictEqual',
553-
stackStartFn: notDeepStrictEqual
553+
stackStartFn: notDeepStrictEqual,
554554
});
555555
}
556556
}
@@ -572,7 +572,7 @@ assert.strictEqual = function strictEqual(actual, expected, message) {
572572
expected,
573573
message,
574574
operator: 'strictEqual',
575-
stackStartFn: strictEqual
575+
stackStartFn: strictEqual,
576576
});
577577
}
578578
};
@@ -594,7 +594,7 @@ assert.notStrictEqual = function notStrictEqual(actual, expected, message) {
594594
expected,
595595
message,
596596
operator: 'notStrictEqual',
597-
stackStartFn: notStrictEqual
597+
stackStartFn: notStrictEqual,
598598
});
599599
}
600600
};
@@ -627,7 +627,7 @@ function compareExceptionKey(actual, expected, key, message, keys, fn) {
627627
actual: a,
628628
expected: b,
629629
operator: 'deepStrictEqual',
630-
stackStartFn: fn
630+
stackStartFn: fn,
631631
});
632632
err.actual = actual;
633633
err.expected = expected;
@@ -639,7 +639,7 @@ function compareExceptionKey(actual, expected, key, message, keys, fn) {
639639
expected,
640640
message,
641641
operator: fn.name,
642-
stackStartFn: fn
642+
stackStartFn: fn,
643643
});
644644
}
645645
}
@@ -668,7 +668,7 @@ function expectedException(actual, expected, message, fn) {
668668
expected,
669669
message,
670670
operator: 'deepStrictEqual',
671-
stackStartFn: fn
671+
stackStartFn: fn,
672672
});
673673
err.operator = fn.name;
674674
throw err;
@@ -743,7 +743,7 @@ function expectedException(actual, expected, message, fn) {
743743
expected,
744744
message,
745745
operator: fn.name,
746-
stackStartFn: fn
746+
stackStartFn: fn,
747747
});
748748
err.generatedMessage = generatedMessage;
749749
throw err;
@@ -837,7 +837,7 @@ function expectsError(stackStartFn, actual, error, message) {
837837
expected: error,
838838
operator: stackStartFn.name,
839839
message: `Missing expected ${fnType}${details}`,
840-
stackStartFn
840+
stackStartFn,
841841
});
842842
}
843843

@@ -886,7 +886,7 @@ function expectsNoError(stackStartFn, actual, error, message) {
886886
operator: stackStartFn.name,
887887
message: `Got unwanted ${fnType}${details}\n` +
888888
`Actual message: "${actual && actual.message}"`,
889-
stackStartFn
889+
stackStartFn,
890890
});
891891
}
892892
throw actual;
@@ -955,7 +955,7 @@ assert.ifError = function ifError(err) {
955955
expected: null,
956956
operator: 'ifError',
957957
message,
958-
stackStartFn: ifError
958+
stackStartFn: ifError,
959959
});
960960

961961
// Make sure we actually have a stack trace!
@@ -1020,7 +1020,7 @@ function internalMatch(string, regexp, message, fn) {
10201020
expected: regexp,
10211021
message,
10221022
operator: fn.name,
1023-
stackStartFn: fn
1023+
stackStartFn: fn,
10241024
});
10251025
err.generatedMessage = generatedMessage;
10261026
throw err;
@@ -1064,7 +1064,7 @@ assert.strict = ObjectAssign(strict, assert, {
10641064
equal: assert.strictEqual,
10651065
deepEqual: assert.deepStrictEqual,
10661066
notEqual: assert.notStrictEqual,
1067-
notDeepEqual: assert.notDeepStrictEqual
1067+
notDeepEqual: assert.notDeepStrictEqual,
10681068
});
10691069

10701070
assert.strict.strict = assert.strict;

‎lib/async_hooks.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const {
1818
const {
1919
ERR_ASYNC_CALLBACK,
2020
ERR_ASYNC_TYPE,
21-
ERR_INVALID_ASYNC_ID
21+
ERR_INVALID_ASYNC_ID,
2222
} = require('internal/errors').codes;
2323
const { kEmptyObject } = require('internal/util');
2424
const {
@@ -58,7 +58,7 @@ const {
5858
const {
5959
async_id_symbol, trigger_async_id_symbol,
6060
init_symbol, before_symbol, after_symbol, destroy_symbol,
61-
promise_resolve_symbol
61+
promise_resolve_symbol,
6262
} = internal_async_hooks.symbols;
6363

6464
// Get constants
@@ -251,7 +251,7 @@ class AsyncResource {
251251
enumerable: true,
252252
value: this,
253253
writable: true,
254-
}
254+
},
255255
});
256256
return bound;
257257
}
@@ -270,7 +270,7 @@ const storageHook = createHook({
270270
for (let i = 0; i < storageList.length; ++i) {
271271
storageList[i]._propagate(resource, currentResource, type);
272272
}
273-
}
273+
},
274274
});
275275

276276
class AsyncLocalStorage {

0 commit comments

Comments
 (0)