quic: fix clang-tidy performance-faster-string-find issue

gengjiawen · gengjiawen · commit 09330fc15570 · 2020-06-22T12:02:39.000Z
PR-URL: #33975 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/src/quic/node_quic_crypto.cc b/src/quic/node_quic_crypto.cc
@@ -384,7 +384,7 @@ bool CheckCertNames(
       return false;
   }
 
-  if (name_parts[0].find("*") == std::string::npos ||
+  if (name_parts[0].find('*') == std::string::npos ||
       name_parts[0].find("xn--") != std::string::npos) {
     return host_parts[0] == name_parts[0];
   }

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ bool CheckCertNames(`
`384`	`384`	`return false;`
`385`	`385`	`}`
`386`	`386`
`387`		`- if (name_parts[0].find("*") == std::string::npos \|\|`
	`387`	`+ if (name_parts[0].find('*') == std::string::npos \|\|`
`388`	`388`	`name_parts[0].find("xn--") != std::string::npos) {`
`389`	`389`	`return host_parts[0] == name_parts[0];`
`390`	`390`	`}`