build: make --without-report a no-op

cjihrig · MylesBorins · commit 074c3c144fe9 · 2020-03-24T02:55:07.000-04:00
This commit makes the configure --without-report flag a no-op. This commit also updates a test that depends on the report CLI flags being conditionally present. PR-URL: #32242 Fixes: #26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/configure.py b/configure.py
@@ -538,12 +538,12 @@
     dest='without_npm',
     help='do not install the bundled npm (package manager)')
 
+# Dummy option for backwards compatibility
 parser.add_option('--without-report',
     action='store_true',
-    dest='without_report',
-    help='build without report')
+    dest='unused_without_report',
+    help=optparse.SUPPRESS_HELP)
 
-# Dummy option for backwards compatibility
 parser.add_option('--with-snapshot',
     action='store_true',
     dest='unused_with_snapshot',
@@ -1004,7 +1004,6 @@ def configure_node(o):
     o['variables']['OS'] = 'android'
   o['variables']['node_prefix'] = options.prefix
   o['variables']['node_install_npm'] = b(not options.without_npm)
-  o['variables']['node_report'] = b(not options.without_report)
   o['variables']['debug_node'] = b(options.debug_node)
   o['default_configuration'] = 'Debug' if options.debug else 'Release'
 
diff --git a/test/parallel/test-process-env-allowed-flags-are-documented.js b/test/parallel/test-process-env-allowed-flags-are-documented.js
@@ -59,8 +59,6 @@ const conditionalOpts = [
     filter: (opt) => opt === '--icu-data-dir' },
   { include: process.features.inspector,
     filter: (opt) => opt.startsWith('--inspect') || opt === '--debug-port' },
-  { include: process.config.variables.node_report,
-    filter: (opt) => opt.includes('-report') },
 ];
 documented.forEach((opt) => {
   conditionalOpts.forEach(({ include, filter }) => {
