dns: remove duplicate code

rickyes · targos · commit 06d16cf9ef55 · 2020-04-22T19:42:52.000+02:00
PR-URL: #32664 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/dns.js b/lib/dns.js
@@ -63,11 +63,7 @@ function onlookup(err, addresses) {
   if (err) {
     return this.callback(dnsException(err, 'getaddrinfo', this.hostname));
   }
-  if (this.family) {
-    this.callback(null, addresses[0], this.family);
-  } else {
-    this.callback(null, addresses[0], isIP(addresses[0]));
-  }
+  this.callback(null, addresses[0], this.family || isIP(addresses[0]));
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,7 @@ function onlookup(err, addresses) {`
`63`	`63`	`if (err) {`
`64`	`64`	`return this.callback(dnsException(err, 'getaddrinfo', this.hostname));`
`65`	`65`	`}`
`66`		`- if (this.family) {`
`67`		`- this.callback(null, addresses[0], this.family);`
`68`		`- } else {`
`69`		`- this.callback(null, addresses[0], isIP(addresses[0]));`
`70`		`- }`
	`66`	`+ this.callback(null, addresses[0], this.family \|\| isIP(addresses[0]));`
`71`	`67`	`}`
`72`	`68`
`73`	`69`