http2: fix ping duration calculation

jasnell · jasnell · commit 039cdebe81e2 · 2018-04-12T12:30:36.000-07:00
PR-URL: #19956 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -2617,8 +2617,8 @@ void Http2Session::Http2Ping::Send(uint8_t* payload) {
 }
 
 void Http2Session::Http2Ping::Done(bool ack, const uint8_t* payload) {
-  session_->statistics_.ping_rtt = (uv_hrtime() - startTime_);
-  double duration = (session_->statistics_.ping_rtt - startTime_) / 1e6;
+  session_->statistics_.ping_rtt = uv_hrtime() - startTime_;
+  double duration = session_->statistics_.ping_rtt / 1e6;
 
   Local<Value> buf = Undefined(env()->isolate());
   if (payload != nullptr) {

Original file line number	Diff line number	Diff line change
`@@ -2617,8 +2617,8 @@ void Http2Session::Http2Ping::Send(uint8_t* payload) {`
`2617`	`2617`	`}`
`2618`	`2618`
`2619`	`2619`	`void Http2Session::Http2Ping::Done(bool ack, const uint8_t* payload) {`
`2620`		`- session_->statistics_.ping_rtt = (uv_hrtime() - startTime_);`
`2621`		`- double duration = (session_->statistics_.ping_rtt - startTime_) / 1e6;`
	`2620`	`+ session_->statistics_.ping_rtt = uv_hrtime() - startTime_;`
	`2621`	`+ double duration = session_->statistics_.ping_rtt / 1e6;`
`2622`	`2622`
`2623`	`2623`	`Local<Value> buf = Undefined(env()->isolate());`
`2624`	`2624`	`if (payload != nullptr) {`