You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: BUILDING.md
+44-25Lines changed: 44 additions & 25 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -120,31 +120,31 @@ platforms. This is true regardless of entries in the table below.
120
120
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 <sup>[7](#fn7)</sup> |
121
121
122
122
<emid="fn1">1</em>: GCC 8 is not provided on the base platform. Users will
123
-
need the
124
-
[Toolchain test builds PPA](https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=xenial)
125
-
or similar to source a newer compiler.
123
+
need the
124
+
[Toolchain test builds PPA](https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=xenial)
125
+
or similar to source a newer compiler.
126
126
127
127
<emid="fn2">2</em>: GCC 8 is not provided on the base platform. Users will
Copy file name to clipboardExpand all lines: onboarding.md
+18-10Lines changed: 18 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -51,12 +51,13 @@ onboarding session.
51
51
[Publicizing or hiding organization membership][].
52
52
53
53
* Notifications:
54
-
* Use [https://github.com/notifications](https://github.com/notifications) or
54
+
* Use <https://github.com/notifications> or
55
55
set up email
56
56
* Watching the main repository will flood your inbox (several hundred
57
57
notifications on typical weekdays), so be prepared
58
58
59
59
The project has two venues for real-time discussion:
60
+
60
61
*[`#nodejs-dev`](https://openjs-foundation.slack.com/archives/C019Y2T6STH) on
61
62
the [OpenJS Foundation](https://slack-invite.openjsf.org/)
62
63
@@ -71,7 +72,7 @@ The project has two venues for real-time discussion:
71
72
* The best outcome is for people who come to our issue tracker to feel like
72
73
they can come back again.
73
74
74
-
* You are expected to follow *and* hold others accountable to the
75
+
* You are expected to follow _and_ hold others accountable to the
75
76
[Code of Conduct][].
76
77
77
78
## Managing the issue tracker
@@ -88,7 +89,7 @@ The project has two venues for real-time discussion:
88
89
not perfect, of course. Feel free to apply relevant labels and remove
89
90
irrelevant labels from pull requests and issues.
90
91
*`semver-{minor,major}`:
91
-
* If a change has the remote *chance* of breaking something, use the
92
+
* If a change has the remote _chance_ of breaking something, use the
92
93
`semver-major` label
93
94
* When adding a `semver-*` label, add a comment explaining why you're adding
94
95
it. Do it right away so you don't forget!
@@ -113,27 +114,34 @@ The project has two venues for real-time discussion:
113
114
## Reviewing pull requests
114
115
115
116
* The primary goal is for the codebase to improve.
117
+
116
118
* Secondary (but not far off) is for the person submitting code to succeed. A
117
119
pull request from a new contributor is an opportunity to grow the community.
120
+
118
121
* Review a bit at a time. Do not overwhelm new contributors.
119
122
* It is tempting to micro-optimize. Don't succumb to that temptation. We
120
123
change V8 often. Techniques that provide improved performance today may be
121
124
unnecessary in the future.
125
+
122
126
* Be aware: Your opinion carries a lot of weight!
127
+
123
128
* Nits (requests for small changes that are not essential) are fine, but try to
124
129
avoid stalling the pull request.
125
130
* Identify them as nits when you comment: `Nit: change foo() to bar().`
126
131
* If they are stalling the pull request, fix them yourself on merge.
132
+
127
133
* Insofar as possible, issues should be identified by tools rather than human
128
134
reviewers. If you are leaving comments about issues that could be identified
129
135
by tools but are not, consider implementing the necessary tooling.
136
+
130
137
* Minimum wait for comments time
131
138
* There is a minimum waiting time which we try to respect for non-trivial
132
139
changes so that people who may have important input in such a distributed
133
140
project are able to respond.
134
141
* For non-trivial changes, leave the pull request open for at least 48 hours.
135
142
* If a pull request is abandoned, check if they'd mind if you took it over
136
143
(especially if it just has nits left).
144
+
137
145
* Approving a change
138
146
* Collaborators indicate that they have reviewed and approve of the changes in
139
147
a pull request using GitHub’s approval interface
@@ -159,7 +167,7 @@ The project has two venues for real-time discussion:
0 commit comments