You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To confirm with upcoming markdown lint rule, use `*` for unordered
lists.
PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Copy file name to clipboardExpand all lines: tools/icu/README.md
+20-20Lines changed: 20 additions & 20 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,25 +4,25 @@ This directory contains tools, data, and information about the [ICU](http://icu-
4
4
(International Components for Unicode) integration. ICU is used to provide
5
5
internationalization functionality.
6
6
7
-
-`patches/` are one-off patches, actually entire source file replacements,
7
+
*`patches/` are one-off patches, actually entire source file replacements,
8
8
organized by ICU version number.
9
-
-`icu_small.json` controls the "small" (English only) ICU. It is input to
9
+
*`icu_small.json` controls the "small" (English only) ICU. It is input to
10
10
`icutrim.py`
11
-
-`icu-generic.gyp` is the build file used for most ICU builds within ICU.
11
+
*`icu-generic.gyp` is the build file used for most ICU builds within ICU.
12
12
<!-- have fun -->
13
-
-`icu-system.gyp` is an alternate build file used when `--with-intl=system-icu`
13
+
*`icu-system.gyp` is an alternate build file used when `--with-intl=system-icu`
14
14
is invoked. It builds against the `pkg-config` located ICU.
15
-
-`iculslocs.cc` is source for the `iculslocs` utility, invoked by `icutrim.py`
15
+
*`iculslocs.cc` is source for the `iculslocs` utility, invoked by `icutrim.py`
16
16
as part of repackaging. Not used separately. See source for more details.
17
-
-`no-op.cc` — empty function to convince gyp to use a C++ compiler.
18
-
-`README.md` — you are here
19
-
-`shrink-icu-src.py` — this is used during upgrade (see guide below)
17
+
*`no-op.cc` — empty function to convince gyp to use a C++ compiler.
18
+
*`README.md` — you are here
19
+
*`shrink-icu-src.py` — this is used during upgrade (see guide below)
20
20
21
21
## How to upgrade ICU
22
22
23
-
- Make sure your Node.js workspace is clean (clean `git status`) should be
23
+
* Make sure your Node.js workspace is clean (clean `git status`) should be
24
24
sufficient.
25
-
- Configure Node.js with the specific [ICU version](http://icu-project.org/download)
25
+
* Configure Node.js with the specific [ICU version](http://icu-project.org/download)
26
26
you want to upgrade to, for example:
27
27
28
28
```shell
@@ -35,12 +35,12 @@ make
35
35
> _Note_ in theory, the equivalent `vcbuild.bat` commands should work also,
36
36
> but the commands below are makefile-centric.
37
37
38
-
- If there are ICU version-specific changes needed, you may need to make changes
38
+
* If there are ICU version-specific changes needed, you may need to make changes
39
39
in `icu-generic.gyp` or add patch files to `tools/icu/patches`.
40
-
- Specifically, look for the lists in `sources!` in the `icu-generic.gyp` for
40
+
* Specifically, look for the lists in `sources!` in the `icu-generic.gyp` for
41
41
files to exclude.
42
42
43
-
- Verify the Node.js build works:
43
+
* Verify the Node.js build works:
44
44
45
45
```shell
46
46
make test-ci
@@ -56,21 +56,21 @@ new Intl.DateTimeFormat('es', {month: 'long'}).format(new Date(9E8));
56
56
57
57
…Should return `January` not `enero`.
58
58
59
-
- Now, copy `deps/icu` over to `deps/icu-small`
59
+
* Now, copy `deps/icu` over to `deps/icu-small`
60
60
61
61
```shell
62
62
python tools/icu/shrink-icu-src.py
63
63
```
64
64
65
-
- Now, do a clean rebuild of Node.js to test:
65
+
* Now, do a clean rebuild of Node.js to test:
66
66
67
67
```shell
68
68
make -k distclean
69
69
./configure
70
70
make
71
71
```
72
72
73
-
- Test this newly default-generated Node.js
73
+
* Test this newly default-generated Node.js
74
74
75
75
<!-- eslint-disable strict -->
76
76
@@ -84,15 +84,15 @@ new Intl.DateTimeFormat('es', {month: 'long'}).format(new Date(9E8));
84
84
You are ready to check in the updated `deps/small-icu`. This is a big commit,
85
85
so make this a separate commit from the smaller changes.
86
86
87
-
- Now, rebuild the Node.js license.
87
+
* Now, rebuild the Node.js license.
88
88
89
89
```shell
90
90
# clean up - remove deps/icu
91
91
make clean
92
92
tools/license-builder.sh
93
93
```
94
94
95
-
- Update the URL and hash for the full ICU file in `tools/icu/current_ver.dep`.
95
+
* Update the URL and hash for the full ICU file in `tools/icu/current_ver.dep`.
96
96
It should match the ICU URL used in the first step. When this is done, the
97
97
following should build with full ICU.
98
98
@@ -104,9 +104,9 @@ make
104
104
make test-ci
105
105
```
106
106
107
-
- commit the change to `tools/icu/current_ver.dep` and `LICENSE` files.
107
+
* commit the change to `tools/icu/current_ver.dep` and `LICENSE` files.
108
108
109
-
- Note: To simplify review, I often will “pre-land” this patch, meaning that
109
+
* Note: To simplify review, I often will “pre-land” this patch, meaning that
110
110
I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch
111
111
| git am -3 --whitespace=fix` per the collaborator’s guide… and then push that
112
112
patched branch into my PR's branch. This reduces the whitespace changes that
0 commit comments