Skip to content

Commit 4b2e498

Browse files
agnatagnat
authored
Merge pull request #952 from striezel-stash/fix-links
Fix outdated links to V8 documentation
2 parents 4e56585 + 8a77313 commit 4b2e498

4 files changed

Lines changed: 16 additions & 16 deletions

File tree

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ Due to the evolution of the V8 API, it is necessary for NAN to provide a wrapper
137137
- <a href="doc/persistent.md#api_nan_weak_callback_info"><b><code>Nan::WeakCallbackInfo</code></b></a>
138138
- <a href="doc/persistent.md#api_nan_weak_callback_type"><b><code>Nan::WeakCallbackType</code></b></a>
139139

140-
Also see the V8 Embedders Guide section on [Handles and Garbage Collection](https://developers.google.com/v8/embed#handles).
140+
Also see the V8 Embedders Guide section on [Handles and Garbage Collection](https://v8.dev/docs/embed#handles-and-garbage-collection).
141141

142142
### New
143143

@@ -227,7 +227,7 @@ NAN includes helpers for creating, throwing and catching Errors as much of this
227227

228228
Note that an Error object is simply a specialized form of `v8::Value`.
229229

230-
Also consult the V8 Embedders Guide section on [Exceptions](https://developers.google.com/v8/embed#exceptions) for more information.
230+
Also consult the V8 Embedders Guide section on [Exceptions](https://v8.dev/docs/embed#exceptions) for more information.
231231

232232
- <a href="doc/errors.md#api_nan_error"><b><code>Nan::Error()</code></b></a>
233233
- <a href="doc/errors.md#api_nan_range_error"><b><code>Nan::RangeError()</code></b></a>

‎doc/errors.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ NAN includes helpers for creating, throwing and catching Errors as much of this
44

55
Note that an Error object is simply a specialized form of `v8::Value`.
66

7-
Also consult the V8 Embedders Guide section on [Exceptions](https://developers.google.com/v8/embed#exceptions) for more information.
7+
Also consult the V8 Embedders Guide section on [Exceptions](https://v8.dev/docs/embed#exceptions) for more information.
88

99
- <a href="#api_nan_error"><b><code>Nan::Error()</code></b></a>
1010
- <a href="#api_nan_range_error"><b><code>Nan::RangeError()</code></b></a>

‎doc/methods.md‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ You do not need to declare a new `HandleScope` within a getter as one is implici
210210

211211
A helper macro `NAN_GETTER(methodname)` exists, compatible with NAN v1 method declarations.
212212

213-
Also see the V8 Embedders Guide documentation on [Accessors](https://developers.google.com/v8/embed#accesssors).
213+
Also see the V8 Embedders Guide documentation on [Accessors](https://v8.dev/docs/embed#accessors).
214214

215215
<a name="api_nan_setter"></a>
216216
### Setter declaration
@@ -237,7 +237,7 @@ You do not need to declare a new `HandleScope` within a setter as one is implici
237237

238238
A helper macro `NAN_SETTER(methodname)` exists, compatible with NAN v1 method declarations.
239239

240-
Also see the V8 Embedders Guide documentation on [Accessors](https://developers.google.com/v8/embed#accesssors).
240+
Also see the V8 Embedders Guide documentation on [Accessors](https://v8.dev/docs/embed#accessors).
241241

242242
<a name="api_nan_property_getter"></a>
243243
### Property getter declaration
@@ -262,7 +262,7 @@ You do not need to declare a new `HandleScope` within a property getter as one i
262262

263263
A helper macro `NAN_PROPERTY_GETTER(methodname)` exists, compatible with NAN v1 method declarations.
264264

265-
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://developers.google.com/v8/embed#interceptors).
265+
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://v8.dev/docs/embed#interceptors).
266266

267267
<a name="api_nan_property_setter"></a>
268268
### Property setter declaration
@@ -287,7 +287,7 @@ You do not need to declare a new `HandleScope` within a property setter as one i
287287

288288
A helper macro `NAN_PROPERTY_SETTER(methodname)` exists, compatible with NAN v1 method declarations.
289289

290-
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://developers.google.com/v8/embed#interceptors).
290+
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://v8.dev/docs/embed#interceptors).
291291

292292
<a name="api_nan_property_enumerator"></a>
293293
### Property enumerator declaration
@@ -308,7 +308,7 @@ You do not need to declare a new `HandleScope` within a property enumerator as o
308308

309309
A helper macro `NAN_PROPERTY_ENUMERATOR(methodname)` exists, compatible with NAN v1 method declarations.
310310

311-
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://developers.google.com/v8/embed#interceptors).
311+
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://v8.dev/docs/embed#interceptors).
312312

313313
<a name="api_nan_property_deleter"></a>
314314
### Property deleter declaration
@@ -331,7 +331,7 @@ You do not need to declare a new `HandleScope` within a property deleter as one
331331

332332
A helper macro `NAN_PROPERTY_DELETER(methodname)` exists, compatible with NAN v1 method declarations.
333333

334-
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://developers.google.com/v8/embed#interceptors).
334+
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://v8.dev/docs/embed#interceptors).
335335

336336
<a name="api_nan_property_query"></a>
337337
### Property query declaration
@@ -354,7 +354,7 @@ You do not need to declare a new `HandleScope` within a property query method as
354354

355355
A helper macro `NAN_PROPERTY_QUERY(methodname)` exists, compatible with NAN v1 method declarations.
356356

357-
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://developers.google.com/v8/embed#interceptors).
357+
Also see the V8 Embedders Guide documentation on named property [Interceptors](https://v8.dev/docs/embed#interceptors).
358358

359359
<a name="api_nan_index_getter"></a>
360360
### Index getter declaration
@@ -376,7 +376,7 @@ You do not need to declare a new `HandleScope` within a index getter as one is i
376376

377377
A helper macro `NAN_INDEX_GETTER(methodname)` exists, compatible with NAN v1 method declarations.
378378

379-
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://developers.google.com/v8/embed#interceptors).
379+
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://v8.dev/docs/embed#interceptors).
380380

381381
<a name="api_nan_index_setter"></a>
382382
### Index setter declaration
@@ -401,7 +401,7 @@ You do not need to declare a new `HandleScope` within a index setter as one is i
401401

402402
A helper macro `NAN_INDEX_SETTER(methodname)` exists, compatible with NAN v1 method declarations.
403403

404-
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://developers.google.com/v8/embed#interceptors).
404+
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://v8.dev/docs/embed#interceptors).
405405

406406
<a name="api_nan_index_enumerator"></a>
407407
### Index enumerator declaration
@@ -422,7 +422,7 @@ You do not need to declare a new `HandleScope` within a index enumerator as one
422422

423423
A helper macro `NAN_INDEX_ENUMERATOR(methodname)` exists, compatible with NAN v1 method declarations.
424424

425-
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://developers.google.com/v8/embed#interceptors).
425+
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://v8.dev/docs/embed#interceptors).
426426

427427
<a name="api_nan_index_deleter"></a>
428428
### Index deleter declaration
@@ -444,7 +444,7 @@ You do not need to declare a new `HandleScope` within a index deleter as one is
444444

445445
A helper macro `NAN_INDEX_DELETER(methodname)` exists, compatible with NAN v1 method declarations.
446446

447-
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://developers.google.com/v8/embed#interceptors).
447+
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://v8.dev/docs/embed#interceptors).
448448

449449
<a name="api_nan_index_query"></a>
450450
### Index query declaration
@@ -466,7 +466,7 @@ You do not need to declare a new `HandleScope` within a index query method as on
466466

467467
A helper macro `NAN_INDEX_QUERY(methodname)` exists, compatible with NAN v1 method declarations.
468468

469-
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://developers.google.com/v8/embed#interceptors).
469+
Also see the V8 Embedders Guide documentation on indexed property [Interceptors](https://v8.dev/docs/embed#interceptors).
470470

471471
<a name="api_nan_set_method"></a>
472472
### Nan::SetMethod()

‎doc/persistent.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Due to the evolution of the V8 API, it is necessary for NAN to provide a wrapper
1212
- <a href="#api_nan_weak_callback_info"><b><code>Nan::WeakCallbackInfo</code></b></a>
1313
- <a href="#api_nan_weak_callback_type"><b><code>Nan::WeakCallbackType</code></b></a>
1414

15-
Also see the V8 Embedders Guide section on [Handles and Garbage Collection](https://developers.google.com/v8/embed#handles).
15+
Also see the V8 Embedders Guide section on [Handles and Garbage Collection](https://v8.dev/docs/embed#handles-and-garbage-collection).
1616

1717
<a name="api_nan_persistent_base"></a>
1818
### Nan::PersistentBase & v8::PersistentBase

0 commit comments

Comments
 (0)