Skip to content

Chore(color): feat with new branding#16

Merged
Trott merged 5 commits intonodejs:mainfrom
AugustinMauroy:main
Jul 11, 2023
Merged

Chore(color): feat with new branding#16
Trott merged 5 commits intonodejs:mainfrom
AugustinMauroy:main

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Member

This PR modifies the colors to match the branding brought with the website redesign.

Comment thread .gitignore Outdated
Comment thread lib/index.js Outdated
Co-authored-by: Rich Trott <[email protected]>
@Trott
Copy link
Copy Markdown
Member

Trott commented May 11, 2023

It would be helpful to have before/after screenshots.

@AugustinMauroy
Copy link
Copy Markdown
Member Author

I will give you one

Comment thread lib/index.js Outdated
@AugustinMauroy
Copy link
Copy Markdown
Member Author

Before:

light :
Capture d’écran 2023-05-11 à 17 35 37
dark :
Capture d’écran 2023-05-11 à 17 35 49

After:

Light :
Capture d’écran 2023-05-11 à 17 34 20
Dark :
Capture d’écran 2023-05-11 à 17 34 30

@Trott
Copy link
Copy Markdown
Member

Trott commented May 11, 2023

Not blocking but for a future PR or for @nodejs/website broader consideration: For maintenance and unstable, both the colors we use now and the colors suggested here fail to meet accessibility requirements for minimum contrast against a white background for graphical objects. (Those requirements are more lenient than they are for regular text.)

We might want to subsequently reconsider those specific colors and either swap in a different colors from the color palette or else update the palette to change those two colors to something else.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented May 15, 2023

Looks good to me, but as @Trott mentioned we might want to change either the background or increase the attenuation of the foreground colours to respect a11y standards.

@AugustinMauroy
Copy link
Copy Markdown
Member Author

I will experiment with some color changes and get back to you with some suggestions

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Jul 11, 2023

Any updates here? :)

@AugustinMauroy
Copy link
Copy Markdown
Member Author

Nop my computer is death ☠️

@Trott
Copy link
Copy Markdown
Member

Trott commented Jul 11, 2023

Looks good to me, but as @Trott mentioned we might want to change either the background or increase the attenuation of the foreground colours to respect a11y standards.

Since the current colors also don't meet a11y contrast requirements, we could consider landing this PR and putting additional a11y-related color changes in a different PR. So we have 1 PR (this one) that aligns us with branding and then a separate one that aligns us with a11y. The second one may require more work because we may need to adjust the palette more broadly than just here. (Hopefully not. Hopefully there are other colors in the palette that we can use.)

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Jul 11, 2023

Fine by me :) LGTM!

@Trott Trott merged commit 7ab3417 into nodejs:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants