Repository navigation
perf: return relaxed header values to the fast scanner - #882
Merged
Merged
Conversation
Member
Author
|
@pimterry PTAL |
ShogunPanda
approved these changes
Sep 26, 2026
ShogunPanda
approved these changes
Oct 1, 2026
rosamarmin
pushed a commit
to artgins/yunetas
that referenced
this pull request
Nov 13, 2026
… goes back to the fast scanner No security fix. A verbatim drop-in over pristine 9.4.3: api.c and http.c byte-identical, llhttp.h only its version, llhttp.c the generated state machine of nodejs/llhttp#882 (a header value, after a byte only the lenient mode accepts, returns to the ordinary vectorized scanner). ghttp_parser.c turns lenient headers on, so every yuno that parses HTTP runs it. THIRD-PARTY-NOTICES and LICENSE-llhttp.txt name 9.4.4; same license. Clean SDK rebuild and full suite: 465/465 (with the test fixes of the next commit; the first run was 464/465, test_c_udp_tx_refused, see there). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013ZKGyx7NpGKnUHixaFcNzG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #881.
The relaxed header-value matcher previously stayed in its own loop, duplicating the ordinary header scanner (including vectorized blocks) in the generated state machine. After accepting a relaxed byte, return to the ordinary
header_valuescanner. Keep invalid bytes on an error path and cover consecutive relaxed bytes and a bare CR following one.Local
-O3standalone benchmarks (4 and 32 headers) improved with clang; gcc remains layout-sensitive. For example, one pinned-core 32-header interleaved run measured ~1,470–1,590 ns/request before and ~1,290–1,350 ns/request after with clang. These numbers are machine/compiler dependent.Validation:
npm test(276 passing),npm run lint,npx tsc --noEmit -p tsconfig.json,git diff --check.