Add fuzzing set up#114
Merged
indutny merged 2 commits intonodejs:masterfrom May 28, 2021
Merged
Conversation
Contributor
|
I'm interested in fuzzing, and I've been using a similar setup for AFL. Note that to get all the paths covered, we need to test the different combinations of lenient settings and both the REQUEST and RESPONSE parsers, not just the default settings with the parser set to BOTH. |
Contributor
|
Here's the current list of lenient settings for reference: |
Signed-off-by: davkor <[email protected]>
Contributor
Author
|
Thanks @pallas - I updated the fuzzer to match your suggestions. |
indutny
approved these changes
May 28, 2021
Member
indutny
left a comment
indutny
left a comment
There was a problem hiding this comment.
LGTM. Fuzzing is great. Let's fuzz all the things!
Member
|
@DavidKorczynski idk if we have a special email address for http parser reports, but you could just use my email from github profile: https://github.com/indutny/ |
Member
|
Thanks for opening this PR! |
elijah-charbel
added a commit
to elijah-charbel/llhttp
that referenced
this pull request
Jul 29, 2025
PR-URL: nodejs/llhttp#114 Reviewed-By: Fedor Indutny <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fuzzing set up to llhttp and OSS-Fuzz - much similar to what we did with http-parser: https://github.com/nodejs/http-parser/tree/master/fuzzers
The OSS-Fuzz set up here: google/oss-fuzz#5850
Is this something you would be interested in? it would be great to get the parser fuzzed - the only thing we will need is an email(s) that will receive bug reports, coverage reports and more.