api: allow returning -1 in spans, doc HPE_USER#104
Closed
Conversation
`HPE_USER` return value was allowed in span callbacks (`on_body`, etc), but wasn't in the documentation. Additionally, looking at the return values of other documented callbacks it was easy to assume that `-1` was a valid return value for spans as well. Instead of returning it as it is change it to `HPE_USER` and add automatic error reason with the span's name.
dnlup
approved these changes
Apr 19, 2021
ronag
approved these changes
Apr 19, 2021
indutny
added a commit
that referenced
this pull request
Apr 20, 2021
`HPE_USER` return value was allowed in span callbacks (`on_body`, etc), but wasn't in the documentation. Additionally, looking at the return values of other documented callbacks it was easy to assume that `-1` was a valid return value for spans as well. Instead of returning it as it is change it to `HPE_USER` and add automatic error reason with the span's name. PR-URL: #104 Reviewed-By: Daniele Belardi <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Member
Author
|
Landed in 1340b32, thanks everyone! |
AdamMajer
pushed a commit
to AdamMajer/llhttp
that referenced
this pull request
Apr 12, 2024
`HPE_USER` return value was allowed in span callbacks (`on_body`, etc), but wasn't in the documentation. Additionally, looking at the return values of other documented callbacks it was easy to assume that `-1` was a valid return value for spans as well. Instead of returning it as it is change it to `HPE_USER` and add automatic error reason with the span's name. PR-URL: nodejs#104 Reviewed-By: Daniele Belardi <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
elijah-charbel
added a commit
to elijah-charbel/llhttp
that referenced
this pull request
Jul 29, 2025
`HPE_USER` return value was allowed in span callbacks (`on_body`, etc), but wasn't in the documentation. Additionally, looking at the return values of other documented callbacks it was easy to assume that `-1` was a valid return value for spans as well. Instead of returning it as it is change it to `HPE_USER` and add automatic error reason with the span's name. PR-URL: nodejs/llhttp#104 Reviewed-By: Daniele Belardi <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPE_USERreturn value was allowed in span callbacks (on_body, etc),but wasn't in the documentation. Additionally, looking at the return
values of other documented callbacks it was easy to assume that
-1wasa valid return value for spans as well. Instead of returning it as it
is change it to
HPE_USERand add automatic error reason with thespan's name.
See: envoyproxy/envoy#15814 (comment)
cc @nodejs/http