This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Update license boilerplate.#390
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom Oct 2, 2017
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sorry, could I ask an offtopic question here? |
Member
|
@andrew-aladev it is not. No new changes doesn't mean being abandoned. |
|
@indutny, Hello. We have here a trivial pull request and nobody wants to merge it. I saw a big amount of good pull requests. For example "Various optimizations". Could you notify project's authors somehow? |
The boilerplate included attribution to NGINX that created confusion because NGINX is distributed under a different license (BSD, not MIT.) To the best of everyone's knowledge, no actual NGINX code remains. Remove the attribution to clear up the confusion. Fixes: nodejs#389 PR-URL: nodejs#390 Reviewed-By: Fedor Indutny <[email protected]>
ploxiln
pushed a commit
to ploxiln/http-parser
that referenced
this pull request
Mar 20, 2018
The boilerplate included attribution to NGINX that created confusion because NGINX is distributed under a different license (BSD, not MIT.) To the best of everyone's knowledge, no actual NGINX code remains. Remove the attribution to clear up the confusion. Fixes: nodejs#389 PR-URL: nodejs#390 Reviewed-By: Fedor Indutny <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boilerplate included attribution to NGINX that created confusion
because NGINX is distributed under a different license (BSD, not MIT.)
To the best of everyone's knowledge, no actual NGINX code remains.
Remove the attribution to clear up the confusion.
Refs: #389