gyp: update shebang lines from python to python3#94
Merged
targos merged 1 commit intonodejs:masterfrom Feb 18, 2021
Merged
Conversation
This is mostly to make Fedora's .rpm builder happy. But it won't hurt now that Python 2 is unsupported in gyp-next.
targos
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fedora's
.rpmpackage builder errors out upon encountering "ambiguous"pythonshebangs. Now that Python 2 support is dropped fromgyp-next, it shouldn't hurt to switch these topython3.See conversation at nodejs/node-gyp#2300 (comment) for more details of why I'm opening this Pull Request.
See also Fedora's policy about this: https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
Thanks.