Skip to content

fix(msvs): correctly rename object files for absolute paths#71

Merged
targos merged 2 commits intonodejs:masterfrom
targos:fix-abs-sourcepath
Oct 14, 2020
Merged

fix(msvs): correctly rename object files for absolute paths#71
targos merged 2 commits intonodejs:masterfrom
targos:fix-abs-sourcepath

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Oct 14, 2020

No description provided.

Copy link
Copy Markdown
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Oct 14, 2020

weird fix, but ok, if this fixes it let's get this merged and pushed out in node-gyp

Co-authored-by: Christian Clauss <[email protected]>
@targos targos merged commit f2c7618 into nodejs:master Oct 14, 2020
@targos targos deleted the fix-abs-sourcepath branch October 14, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants