build: support apple silicon (arm64 darwin) builds#49
build: support apple silicon (arm64 darwin) builds#49ryzokuken merged 2 commits intonodejs:masterfrom
Conversation
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM overall. Is there absolutely any way to be able to test this though?
|
We will have to monitor https://blog.macstadium.com/category/macstadium-news to see when the new Apple hardware is added. |
|
You can test the "build" part using any machine with the Xcode 12.0 UA preview on it, but you won't be able to ensure it actually runs / works without an apple-silicon machine somewhere. Definitely works on my DTK though 😄 |
|
@MarshallOfSound great. I'll merge this in after another review and once that's done I suppose we could make a minor release with this. Would you mind adding this to the changelog file? |
|
@ryzokuken Updated |
ryzokuken
left a comment
There was a problem hiding this comment.
Thanks @MarshallOfSound.
Pairs with nodejs/node-gyp#2165