Skip to content

Python fixes for ruff v0.11.0 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 1 commit into from
Mar 19, 2025
Merged

Python fixes for ruff v0.11.0 #286

cclauss merged 1 commit into from
Mar 19, 2025

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 18, 2025 •
edited
Loading

@cclauss cclauss requested a review from legendecas March 18, 2025 12:49
@cclauss cclauss added the python Pull requests that update Python code label Mar 18, 2025
@cclauss cclauss mentioned this pull request Mar 18, 2025
Merged
@legendecas
Copy link
Member

legendecas commented Mar 18, 2025

The wasm test is failing on the main branch as well: https://github.com/nodejs/gyp-next/actions/runs/13924144412

@legendecas
Copy link
Member

legendecas commented Mar 18, 2025

@toyobayashi would you mind helping us identifying the issue? Thank you!

@toyobayashi
Copy link
Contributor

toyobayashi commented Mar 19, 2025

It seems that the latest version Visual Studio LLVM clang doesn't support wasm32 target...

> C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools>"C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\Llvm\bin\clang.exe" -print-targets

  Registered Targets:
    aarch64    - AArch64 (little endian)
    aarch64_32 - AArch64 (little endian ILP32)
    aarch64_be - AArch64 (big endian)
    arm        - ARM
    arm64      - ARM64 (little endian)
    arm64_32   - ARM64 (little endian ILP32)
    armeb      - ARM (big endian)
    thumb      - Thumb
    thumbeb    - Thumb (big endian)
    x86        - 32-bit X86: Pentium-Pro and above
    x86-64     - 64-bit X86: EM64T and AMD64

After I switch CC_target to wasi-sdk on my local machine, it's ok.

@cclauss cclauss mentioned this pull request Mar 19, 2025
Closed
@cclauss
Copy link
Contributor Author

cclauss commented Mar 19, 2025 •
edited
Loading

Can I please get approval on the Python-related changes in this pull request?

We can move the Windows wasm discussion to

@cclauss cclauss merged commit 80f7771 into nodejs:main Mar 19, 2025
36 of 40 checks passed
@cclauss cclauss deleted the python-fixes-for-ruff-v0.11.0 branch March 19, 2025 08:37
@cclauss cclauss mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes

@lukekarrys lukekarrys Awaiting requested review from lukekarrys

@gengjiawen gengjiawen Awaiting requested review from gengjiawen

Assignees

@legendecas legendecas

Labels

python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @legendecas @toyobayashi