chore: dependencies = setuptools for gyp --version on Python >= 3.12#256
Merged
legendecas merged 3 commits intomainfrom May 26, 2024
Merged
Conversation
gyp --version on Python >= 3.12
ryzokuken
approved these changes
May 9, 2024
legendecas
reviewed
May 9, 2024
This was referenced May 17, 2024
…ect.toml Co-authored-by: Chengzhong Wu <[email protected]>
legendecas
approved these changes
May 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
On Python >= 3.12
%
pipx run --no-cache --spec git+https://github.com/nodejs/gyp-next.git gyp --helpwas erroring with%
pipx run --no-cache --spec git+https://github.com/nodejs/gyp-next.git gyp --versionis still erroring withgyp --helpwas fixed in gyp-next v0.18.0gyp --versionwas notSince both modules are included
setuptoolslet's use that recommended fix.Proof:
%
pipx install gyp-next%
gyp --version# Fails!%
pipx inject gyp-next setuptools# This is the same action as this pull request.%
gyp --version# Works as expected.%
gyp --help# Works as expected.