Skip to content

chore: setup release automation#248

Merged
legendecas merged 2 commits intonodejs:mainfrom
legendecas:publish-action
May 24, 2024
Merged

chore: setup release automation#248
legendecas merged 2 commits intonodejs:mainfrom
legendecas:publish-action

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Apr 30, 2024

@targos
Copy link
Member

targos commented Apr 30, 2024

I appreciate the work you put in this, but we're already using release-please to create the release, so I'm surprised you're not adding something to the existing workflow.

@legendecas
Copy link
Member Author

release-please doesn't publish the package to the registry. I'll merge the two workflow so that they can be pipelined. Thanks for the suggestion!

@legendecas legendecas marked this pull request as ready for review May 9, 2024 09:29
@legendecas legendecas force-pushed the publish-action branch 2 times, most recently from d1266b1 to c7c0c1d Compare May 9, 2024 09:32
@legendecas
Copy link
Member Author

This is ready for review. I ran it on my own repo and published https://test.pypi.org/project/gyp-next/0.18.0.post1/

@cclauss
Copy link
Contributor

cclauss commented May 9, 2024

@legendecas
Copy link
Member Author

Well, yeah, no idea why pypi api isn't supported.

@targos
Copy link
Member

targos commented May 21, 2024

@legendecas legendecas#2

@legendecas
Copy link
Member Author

legendecas commented May 23, 2024

@cclauss @targos would you mind taking a look again? thank you!

@targos
Copy link
Member

targos commented May 24, 2024

I'd prefer someone else to review as I did part of the changes and I'm not familiar with the release of Python packages.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It looks perfect! Nice work!

@legendecas legendecas merged commit 29fa534 into nodejs:main May 24, 2024
@legendecas legendecas deleted the publish-action branch May 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants