feat: add PRODUCT_DIR_ABS variable#151
Merged
gengjiawen merged 1 commit intonodejs:mainfrom May 11, 2022
Merged
Conversation
targos
approved these changes
May 11, 2022
richardlau
reviewed
Apr 25, 2023
| else: | ||
| default_variables.setdefault( | ||
| "PRODUCT_DIR_ABS", | ||
| os.path.join(output_dir, default_variables["CONFIGURATION_NAME"]), |
Member
There was a problem hiding this comment.
Was there a reason this is different from nodejs/node@f4bd91b#diff-b444d542a5859a68304f84ed3e5a6c81730671295236c26c7866eab5306c1d11 where both ninja and non-ninja paths used default_variables["build_type"]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.