Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/gyp-next
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.22.0
Choose a base ref
...
head repository: nodejs/gyp-next
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.1
Choose a head ref
  • 5 commits
  • 9 files changed
  • 3 contributors

Commits on Apr 7, 2026

  1. chore: fix ruff check (#337)

    Co-authored-by: Christian Clauss <[email protected]>
    legendecas and cclauss authored Apr 7, 2026
    Configuration menu
    Copy the full SHA
    f8c83b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2026

  1. Configuration menu
    Copy the full SHA
    147fa1a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2026

  1. msvs.py: Use floor division when escaping command-line arguments (#338)

    Fixes nodejs/node-gyp#3296
    * nodejs/node-gyp#3296
    
    % `python3.14`
    ```
    >>> import re
    >>> s = "TEST_STRING=\\\"TEST\\\""
    >>> quote_replacer_regex2 = re.compile(r'(\\+)"')
    ...
    ...
    ... def _EscapeCommandLineArgumentForMSBuild(s):
    ...     """Escapes a Windows command-line argument for use by MSBuild."""
    ...
    ...     def _Replace(match):
    ...         return (len(match.group(1)) / 2 * 4) * "\\" + '\\"'
    ...
    ...     # Escape all quotes so that they are interpreted literally.
    ...     s = quote_replacer_regex2.sub(_Replace, s)
    ...     return s
    ...
    >>> _EscapeCommandLineArgumentForMSBuild(s)
    Traceback (most recent call last):
      File "<python-input-3>", line 1, in <module>
        _EscapeCommandLineArgumentForMSBuild(s)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
      File "<python-input-1>", line 11, in _EscapeCommandLineArgumentForMSBuild
        s = quote_replacer_regex2.sub(_Replace, s)
      File "<python-input-1>", line 8, in _Replace
        return (len(match.group(1)) / 2 * 4) * "\\" + '\\"'
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
    TypeError: can't multiply sequence by non-int of type 'float'
    
    >>> Modify _Replace() to use floor division...
    >>> _EscapeCommandLineArgumentForMSBuild(s)
    'TEST_STRING=\\"TEST\\"'
    cclauss authored Apr 18, 2026
    Configuration menu
    Copy the full SHA
    cadca24 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2026

  1. Fix add dict.items() in dictionary iteration (#341)

    Fix for Windows test blocking:
    * nodejs/node-gyp#/3295
    cclauss authored Apr 21, 2026
    Configuration menu
    Copy the full SHA
    f7085ce View commit details
    Browse the repository at this point in the history
  2. chore(main): release 0.22.1 (#340)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Apr 21, 2026
    Configuration menu
    Copy the full SHA
    91c8e14 View commit details
    Browse the repository at this point in the history
Loading