Switch Debian based image templates to Debian Stretch#887
Switch Debian based image templates to Debian Stretch#887PeterDaveHello merged 3 commits intonodejs:masterfrom
Conversation
PeterDaveHello
requested review from
a team,
LaurentGoderre,
SimenB,
Starefossen and
chorrell
|
I think this PR should just be about switching to stretch. For the slim variant and also the main variant. Then we land the 10.13.0 change and do the docker hub per so users get the update as part of the 10.13.0 update. |
PeterDaveHello
force-pushed
the
switch-slim-base-to-stretch
branch
from
8f6c935 to
ee42543
Compare
|
Updated. |
|
Cool. What's involved on changing the main variant to stretch? I have't looked at this in a while I forget how this was templated. |
|
No I haven't done that yet. |
|
I left a comment over in #885 -- tl;dr; if we want the docker images to follow the same conventions as the LTS release process, at a minimum, we should to bump 11.x to |
PeterDaveHello
changed the title
|
That seems pretty reasonable |
PeterDaveHello
force-pushed
the
switch-slim-base-to-stretch
branch
from
ee42543 to
717e8cc
Compare
|
Updated again. |
|
So maybe should keep v10 to use jessie? |
|
yeah |
|
Don't we need to do the same thing on v8.x as it's also LTS? |
|
Yeah, just v11 should have the changes. |
PeterDaveHello
force-pushed
the
switch-slim-base-to-stretch
branch
from
717e8cc to
1a53c88
Compare
|
So let's just update the templates here, PR updated. |
PeterDaveHello
changed the title
|
@nodejs/docker please help review. |
|
Seems to have a problem with official-image repository CI as we didn't update that for v6~v10, need discussion here: docker-library/official-images#4986 |
|
I guess we need a modified |
|
Cool: #893 |
4 participants
No description provided.