Skip to content

Comments

Update node.js v10.x to v10.13.0#885

Merged
PeterDaveHello merged 1 commit intonodejs:masterfrom
PeterDaveHello:update-node.js
Oct 30, 2018
Merged

Update node.js v10.x to v10.13.0#885
PeterDaveHello merged 1 commit intonodejs:masterfrom
PeterDaveHello:update-node.js

Conversation

@PeterDaveHello
Copy link
Member

@PeterDaveHello PeterDaveHello commented Oct 30, 2018 •
edited
Loading

@chorrell
Copy link
Contributor

chorrell commented Oct 30, 2018

Before merging this, I think we should consider switching to stretch for slim and the main variant so users can pin to a Node.js release. We've let the transition to stretch linger for a while and we need to deal with it

@nschonni
Copy link
Member

nschonni commented Oct 30, 2018

Not sure that switching base images mid-stream would be good for users.

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Oct 30, 2018

@chorrell I've sent a PR here: #887, not sure if this is what you mean, please take a look.

@chorrell
Copy link
Contributor

chorrell commented Oct 30, 2018

@nschonni The change would coincide to a Node.js release so users can pin to a specific version of node if they want. I don't really consider this "mid-stream" and we can't keep putting this off.

@schmod
Copy link

schmod commented Oct 30, 2018

Given that 10.13 is LTS, I don't think you should be making any major changes that haven't already been sitting on a current release (now the 11.x series) for one full release (and, to be perfectly honest, it may not be wise to make this kind of change at all to an active LTS series -- the correct time to make this change would have been a month ago).

See nodejs/Release#279 for some context.

@schmod schmod mentioned this pull request Oct 30, 2018
Merged
@chorrell
Copy link
Contributor

chorrell commented Oct 30, 2018 •
edited
Loading

Fair. So I guess for now we just make the switch to the v11 release?

@chorrell chorrell mentioned this pull request Oct 30, 2018
Merged
@PeterDaveHello PeterDaveHello merged commit 33105dc into nodejs:master Oct 30, 2018
@PeterDaveHello PeterDaveHello deleted the update-node.js branch October 30, 2018 18:58
@knksmith57 knksmith57 mentioned this pull request Oct 30, 2018
Merged
@bizob2828
Copy link

bizob2828 commented Oct 30, 2018

n00b question, how long does it take to update docker hub? I don't see this available yet

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Oct 31, 2018

@bizob2828 we're working on it, will be soon.

@PeterDaveHello PeterDaveHello mentioned this pull request Nov 1, 2018
Merged
@arroyc arroyc mentioned this pull request Nov 1, 2018
Closed
@bizob2828
Copy link

bizob2828 commented Nov 1, 2018

@PeterDaveHello I still don't see it on docker hub, is it just me or is this still pending?

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Nov 1, 2018

We're working on it, will be soon in a few days.

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Nov 2, 2018

It's now avaliable!

Peter ~ $ for tag in 10.13.0 11.0.0 ; do docker pull node:$tag ; done
10.13.0: Pulling from library/node
61be48634cb9: Pull complete 
fa696905a590: Pull complete 
b6dd2322bbef: Pull complete 
32477089adb4: Pull complete 
febe7209ec28: Pull complete 
4364cbe57162: Pull complete 
529b9fcd8a55: Pull complete 
d5ca2d5eff34: Pull complete 
Digest: sha256:51bbebc2448556864de739a0c503aa9ac78798e1ae62a38de6ba6ed758e1cbf6
Status: Downloaded newer image for node:10.13.0
11.0.0: Pulling from library/node
bc9ab73e5b14: Pull complete 
193a6306c92a: Pull complete 
e5c3f8c317dc: Pull complete 
a587a86c9dcb: Pull complete 
72744d0a318b: Pull complete 
ae625339181e: Pull complete 
c25b903bb862: Pull complete 
a51c020843e8: Pull complete 
f5fd35b7fb44: Pull complete 
Digest: sha256:e02c9963a48fe3b7e134ebfaf8aca75fef7f4988234c8c48aa84ec9294d35942
Status: Downloaded newer image for node:11.0.0


Peter ~ $ for tag in 10.13.0 11.0.0 ; do docker pull node:$tag-alpine ; done
10.13.0-alpine: Pulling from library/node
4fe2ade4980c: Pull complete 
e4ac5f64a73e: Pull complete 
f62e97d98767: Pull complete 
Digest: sha256:44e21b14877bdb7375af498437fac4c93392bf4a500696ef17bd216b4fffcb58
Status: Downloaded newer image for node:10.13.0-alpine
11.0.0-alpine: Pulling from library/node
4fe2ade4980c: Already exists 
4fe6fc3d4500: Pull complete 
d48fd3011df1: Pull complete 
Digest: sha256:9df9329306194c156863c74e97e43b54aee3884940b971e87c5c1db2f82c766a
Status: Downloaded newer image for node:11.0.0-alpine

Peter ~ $ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
node                10.13.0-alpine      e35872f034fd        4 hours ago         70.2 MB
node                10.13.0             5432ebbc244b        5 hours ago         674 MB
node                11.0.0              ad73966fd12e        5 hours ago         894 MB
node                11.0.0-alpine       5d526f8ba00b        5 hours ago         71.1 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Starefossen Starefossen Awaiting requested review from Starefossen

@LaurentGoderre LaurentGoderre Awaiting requested review from LaurentGoderre

@SimenB SimenB Awaiting requested review from SimenB

1 more reviewer

@chorrell chorrell chorrell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PeterDaveHello @chorrell @nschonni @schmod @bizob2828