Skip to content

feat: Node.js 20.0.0#1882

Merged
nschonni merged 1 commit intonodejs:mainfrom
smorimoto:node20
Apr 19, 2023
Merged

feat: Node.js 20.0.0#1882
nschonni merged 1 commit intonodejs:mainfrom
smorimoto:node20

Conversation

@smorimoto
Copy link
Copy Markdown
Contributor

@smorimoto smorimoto commented Apr 18, 2023

Description

As the title says...

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

This was referenced Apr 18, 2023
Merged
Merged
@nschonni
Copy link
Copy Markdown
Member

nschonni commented Apr 18, 2023

Currently blocked on nodejs/unofficial-builds#76, since I think these are the current Apline hashes for v19 rather than v20

@seanhamlin seanhamlin mentioned this pull request Apr 18, 2023
Closed
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Apr 19, 2023

Yes, this is definitely blocked on that 🙂
I will update this PR as soon as the files are deployed successfully. (Or I'm allowing editing, so it's fine if someone can do that while I'm away 😉)

@smorimoto
feat: Node.js 20.0.0
2ba234d 
Signed-off-by: Sora Morimoto <[email protected]>
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Apr 19, 2023

I just updated the hash value. Can anyone kick the CI?

@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Apr 19, 2023

Good, now this passes all the CI 🙂

@nschonni nschonni merged commit d5d36cb into nodejs:main Apr 19, 2023
@smorimoto smorimoto deleted the node20 branch April 19, 2023 17:04
@nodejs-github-bot nodejs-github-bot mentioned this pull request Apr 19, 2023
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2023

Created PR on the official-images repo (docker-library/official-images#14474). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Apr 19, 2023

@nschonni Thank you for taking care of this!

@nschonni
Copy link
Copy Markdown
Member

nschonni commented Apr 19, 2023

Thanks for submitting it @smorimoto!

@jnoordsij jnoordsij mentioned this pull request Oct 18, 2023
Merged
12 tasks
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 24, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschonni nschonni nschonni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smorimoto @nschonni