Add .d.mts file#85
Merged
guybedford merged 1 commit intonodejs:mainfrom May 15, 2023
Merged
Conversation
Contributor
Author
|
cc @guybedford |
Collaborator
|
Looks ok to me. Thanks @Andarist. |
guybedford
approved these changes
May 15, 2023
Contributor
Author
|
@guybedford would you be able to cut a new release with this small change? |
Collaborator
|
@Andarist sure, I've published a 1.2.3, let me know if that is working ok for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved
typescondition to the front.package.json#exportsare order-sensitive - they are always matched from the top to the bottom. When a match is found then it should be used and no further matching should occur.Right now, the current setup works in TypeScript but it's considered a bug and it should not be relied upon, see the thread and the comment here. For that reason, I would like to fix all popular packages that misconfigured their
exportsthis way so the bug can be fixed in TypeScript.🎭 Masquerading as CJS) should also get fixed by this. Reexporting types like this isn't technically 100% correct (your implementation is duplicated between CJS and ESM and so the types should be too) but I think it's fairly OK to do it this way here since you don't export any nominal types or anything like that.