Support RollupJS reexports property checks#41
Merged
guybedford merged 3 commits intomasterfrom Mar 8, 2021
Merged
Conversation
| if (ch !== 33/*!*/) break; | ||
| pos += 1; | ||
| ch = commentWhitespace(); | ||
| if (source.startsWith(id, pos)) { |
Contributor
There was a problem hiding this comment.
Which tool uses exports.hasOwnProperty?
Collaborator
Author
There was a problem hiding this comment.
RollupJS just does this now as per #38. I'm not sure if there's anything for the collision case, that's why I added the Object.hasOwnProperty as well in case that gets added in future //cc @lukastaegert.
nicolo-ribaudo
approved these changes
Mar 7, 2021
haoqunjiang
reviewed
Jul 12, 2021
| }); | ||
|
|
||
| Object.keys(external6).forEach(function (k) { | ||
| if (k !== 'default' && !external6.hasOwnProperty(k)) exports[k] = external6[k]; |
There was a problem hiding this comment.
It's exports.hasOwnProperty not external6.hasOwnProperty 😅
Collaborator
Author
There was a problem hiding this comment.
Thanks for spotting this, wish we'd got this on the first review! Posted #59.
Collaborator
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! I think it works correctly now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
This extends the
p !== 'default'pattern to add the!exports.hasOwnProperty(p)reexports check as well. I've also included a check forObject.hasOwnProperty.call(exports, p)for the case if RollupJS ever decides to use this form as well.//cc @nicolo-ribaudo for review. I've also refactored the Babel hasOwnProperty check here making the
prototypeoptional.