lookup: avoid browser testing for through2#810
Merged
richardlau merged 2 commits intonodejs:masterfrom Jul 1, 2020
Merged
Conversation
Use a different npm script to avoid browser tests for through2 and sort the keys for the through2 entry in lookup.json.
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 30 30
Lines 889 889
=======================================
Hits 855 855
Misses 34 34 Continue to review full report at Codecov.
|
Member
Author
|
(Looks like failures on AIX and Windows) |
Member
Author
|
Added skips for AIX and Windows.
|
BethGriggs
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a different npm script to avoid browser tests for through2 and sort
the keys for the through2 entry in lookup.json.
Fixes: #809
Checklist
npm testpasseshere