Skip to content

lookup: add node-gyp#370

Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau:node-gyp
Closed

lookup: add node-gyp#370
richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau:node-gyp

Conversation

@richardlau
Copy link
Copy Markdown
Member

@richardlau richardlau commented Feb 27, 2017

Checklist
  • commit message follows commit guidelines

Add node-gyp to lookup.json. I believe it meets all the hard requirements for inclusion.

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Feb 27, 2017 

-bash-4.2$ bin/citgm.js node-gyp
info:    starting            | node-gyp
warn:    update-available    | v1.11.2 (current: v1.11.1)
warn:                        | npm install -g citgm
info:    lookup              | node-gyp
info:    lookup-found        | node-gyp
info:    node-gyp lookup-replace| https://github.com/nodejs/node-gyp/archive/v3.5.0.tar.gz
info:    node-gyp npm:       | Downloading project: https://github.com/nodejs/node-gyp/archive/v3.5.0.tar.gz
info:    node-gyp npm:       | Project downloaded node-gyp-3.5.0.tgz
info:    node-gyp npm:       | npm install started
info:    node-gyp npm:       | npm install successfully completed
info:    node-gyp npm:       | test suite started
info:    passing module(s)   |
info:    module name:        | node-gyp
info:    version:            | 3.5.0
info:    done                | The smoke test has passed.
info:    duration            | test duration: 23547ms
-bash-4.2$

gdams

This comment was marked as off-topic.

Sign in to view

@gdams
Copy link
Copy Markdown
Member

gdams commented Feb 27, 2017

v4: https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/116/
v6: https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/117/
v7: https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/118/

MylesBorins

This comment was marked as off-topic.

Sign in to view

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Feb 27, 2017

Related: nodejs/testing#15

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Feb 27, 2017

Looking into AIX failures:

e.g. https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/118/MACHINE=aix61-ppc64/console

error:                     | > [email protected] test /home/iojs/build/workspace/gibfahn-citgm-smoker-more-platforms/MACHINE/aix61-ppc64/citgm_tmp/3b837526-ee7e-4adc-b864-e7eb3c47f327/node-gyp                                   
error:                     | > tape test/test-*                                                                                                                                                                                 
error:                     |                                                                                                                                                                                                    
error:                     | TAP version 13                                                                                                                                                                                     
error:                     | # build simple addon                                                                                                                                                                               
error:                     | ok 1 should be equal                                                                                                                                                                               
error:                     | ok 2 should end in ok                                                                                                                                                                              
error:                     | ok 3 should be equal                                                                                                                                                                               
error:                     | # configure PYTHONPATH with no existing env                                                                                                                                                        
error:                     |                                                                                                                                                                                                    
error:                     | gyp ERR! find exports file Could not find exports file                                                                                                                                             
error:                     | /home/iojs/build/workspace/gibfahn-citgm-smoker-more-platforms/MACHINE/aix61-ppc64/citgm_tmp/3b837526-ee7e-4adc-b864-e7eb3c47f327/node-gyp/lib/configure.js:245                                    
error:                     | return callback(new Error(msg))                                                                                                                                                                    
error:                     | ^                                                                                                                                                                                                  
error:                     |                                                                                                                                                                                                    
error:                     | TypeError: callback is not a function                                                                                                                                                              
error:                     | at runGyp (/home/iojs/build/workspace/gibfahn-citgm-smoker-more-platforms/MACHINE/aix61-ppc64/citgm_tmp/3b837526-ee7e-4adc-b864-e7eb3c47f327/node-gyp/lib/configure.js:245:16)                     
error:                     | at findConfigs (/home/iojs/build/workspace/gibfahn-citgm-smoker-more-platforms/MACHINE/aix61-ppc64/citgm_tmp/3b837526-ee7e-4adc-b864-e7eb3c47f327/node-gyp/lib/configure.js:170:23)                
...

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Feb 27, 2017

It's a problem with one of the node-gyp tests (test/test-configure-python.js) on AIX. I'll upstream a fix.

@gdams
Copy link
Copy Markdown
Member

gdams commented Feb 27, 2017

Sgtm

@richardlau richardlau mentioned this pull request Feb 27, 2017
Closed
@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Feb 27, 2017 •
edited
Loading

Raised nodejs/node-gyp#1131. It's unfortunate this test has never passed on AIX, but hey all the more reason to add node-gyp to CITGM 😆

@richardlau richardlau mentioned this pull request Mar 1, 2017
Closed
@gdams
Copy link
Copy Markdown
Member

gdams commented Apr 5, 2017

@richardlau any progress with this?

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented Apr 5, 2017

Still waiting for nodejs/node-gyp#1131 to land.

@gdams
Copy link
Copy Markdown
Member

gdams commented Apr 18, 2017

@nodejs-github-bot run CI

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 18, 2017

@gdams build started: https://ci.nodejs.org/job/citgm-continuous-integration-pipeline/

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented May 3, 2017

nodejs/node-gyp#1131 has landed in [email protected] so I think this is unblocked now.

I've rebased onto the current master and added a native tag. PTAL.

@richardlau
Copy link
Copy Markdown
Member Author

richardlau commented May 3, 2017

@nodejs-github-bot run CI

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 3, 2017

@richardlau sadly an error occured when I tried to trigger a build :(

@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented May 22, 2017

landed in 92f1d6e

@richardlau richardlau mentioned this pull request Mar 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@gdams gdams gdams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

additional-modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau @gdams @nodejs-github-bot @MylesBorins