Merged
Conversation
richardlau
approved these changes
Mar 2, 2023
PR-URL: nodejs#3211 Reviewed-By: Richard Lau <[email protected]>
This is required to migrate from WiX3 to WiX4 for building the Node msi. Refs: nodejs/node#45943 PR-URL: nodejs#3211 Reviewed-By: Richard Lau <[email protected]>
Windows 10 and 11 machines occasionally show finish setting up device screen thus preventing Jenkins from starting after reboot. These changes disable that behavior. Refs: nodejs#3046 PR-URL: nodejs#3211 Reviewed-By: Richard Lau <[email protected]>
Refs: nodejs-private/secrets#246 PR-URL: nodejs#3211 Reviewed-By: Richard Lau <[email protected]>
StefanStojanovic
force-pushed
the
mefi-windows-update
branch
from
e7d9298 to
1566a93
Compare
StefanStojanovic
pushed a commit
that referenced
this pull request
Mar 8, 2023
PR-URL: #3211 Reviewed-By: Richard Lau <[email protected]>
StefanStojanovic
added a commit
that referenced
this pull request
Mar 8, 2023
This is required to migrate from WiX3 to WiX4 for building the Node msi. Refs: nodejs/node#45943 PR-URL: #3211 Reviewed-By: Richard Lau <[email protected]>
StefanStojanovic
added a commit
that referenced
this pull request
Mar 8, 2023
Windows 10 and 11 machines occasionally show finish setting up device screen thus preventing Jenkins from starting after reboot. These changes disable that behavior. Refs: #3046 PR-URL: #3211 Reviewed-By: Richard Lau <[email protected]>
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Mar 23, 2023
Refs: nodejs#45943 Refs: nodejs#47020 Refs: nodejs/build#3046 Refs: nodejs/build#3246 Refs: nodejs/build#3250 Refs: nodejs/build#3211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a few changes for Windows machines in the CI: