ansible: fix multiple register vars on Fedora#2654
Merged
richardlau merged 1 commit intonodejs:masterfrom May 24, 2021
Merged
Conversation
Tasks registering variables in Ansible will alway set the variable regardless of any `when` clause(s). This means if more than one task registers the same variable, the last one "wins". Fix the bootstrap role on Fedora by correctly registering `has_libselinux` in both `fedora30` and non-`fedora30` cases.
55 tasks
AshCripps
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks registering variables in Ansible will alway set the variable
regardless of any
whenclause(s). This means if more than one taskregisters the same variable, the last one "wins". Fix the bootstrap
role on Fedora by correctly registering
has_libselinuxin bothfedora30and non-fedora30cases.Refs: #2531
Fixes this error: