ansible: fix scripts for LinuxONE and SmartOS#2569
Merged
richardlau merged 1 commit intonodejs:masterfrom Mar 15, 2021
Merged
Conversation
Move non-package manager ccache tasks into partial tasks to avoid the different platforms interfering which each other.
Member
Author
|
One thing I've not changed is the version of ccache being installed, which on AIX, LinuxONE and SmartOS is not the latest (3.7.2 on AIX and 3.6 on LinuxONE and SmartOS). The replaced I'd prefer to look at that separately in a follow up PR if necessary. |
AshCripps
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move non-package manager ccache tasks into partial tasks to
avoid the different platforms interfering which each other.
Fixes: #2533
This refactors by replacing
ansible/roles/baselayout/tasks/ccache.ymlandplatform specific ccache tasks in
ansible/roles/baselayout/tasks/main.ymlwith platform specific versions under
ansible/roles/baselayout/tasks/partials/ccache.