Skip to content

pipelines: add lint-py to linter pipeline#1745

Merged
richardlau merged 2 commits intonodejs:masterfrom
refack:add-python-linting
Jan 28, 2020
Merged

pipelines: add lint-py to linter pipeline#1745
richardlau merged 2 commits intonodejs:masterfrom
refack:add-python-linting

Conversation

@refack
Copy link
Copy Markdown
Contributor

@refack refack commented Mar 27, 2019 •
edited
Loading

fixes: #1631

example output (master):

18:38:04  + python tools/getnodeversion.py
18:38:05  [Pipeline] sh
18:38:09  + NODE=node PYTHON=python3 gmake lint-py
18:38:09  PYTHONPATH=tools/pip python3 -m flake8 . \
18:38:09  	--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
18:38:09  	--exclude=.git,deps,lib,src,test/fixtures,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
18:38:18  0
18:38:19  [Pipeline] sh
18:38:22  + NODE=node gmake lint-ci
18:38:22  Running JS linter...
18:39:43  Running C++ linter...
18:40:19  PYTHONPATH=tools/pip python -m flake8 . \
18:40:19  	--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
18:40:19  	--exclude=.git,deps,lib,src,test/fixtures,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
18:40:25  0

v10.x-staging:

18:43:20  + python tools/getnodeversion.py
18:43:20  [Pipeline] sh
18:43:22  + NODE=node gmake lint-ci

v8.x-staging - https://ci.nodejs.org/job/node-linter/3040/console

19:19:36  + python tools/getnodeversion.py
19:19:37  [Pipeline] echo
19:19:37  8.15.2
19:19:37  [Pipeline] sh
19:19:38  + NODE=node gmake lint-ci
19:19:38  Running JS linter...
19:20:19  Running C++ linter on addon docs...

@refack refack self-assigned this Mar 27, 2019
@refack refack mentioned this pull request Mar 27, 2019
Closed
richardlau
richardlau reviewed Mar 27, 2019
View reviewed changes
Comment thread jenkins/pipelines/node-linter.jenkinsfile Outdated
@refack refack force-pushed the add-python-linting branch from 4f535f4 to 2e75cd2 Compare March 27, 2019 23:01
richardlau
richardlau reviewed Mar 28, 2019
View reviewed changes
Comment thread jenkins/pipelines/node-linter.jenkinsfile Outdated
@richardlau
Copy link
Copy Markdown
Member

richardlau commented Mar 28, 2019

Oh and you've mispelled linter in the commit message and PR title 😆.

@refack refack force-pushed the add-python-linting branch from 562f2b3 to ddad8de Compare March 28, 2019 12:41
@refack refack changed the title pipelines: add lint-py to liter pipeline pipelines: add lint-py to linter pipeline Mar 28, 2019
@refack refack force-pushed the add-python-linting branch from ddad8de to 024d423 Compare March 28, 2019 12:43
@refack
Copy link
Copy Markdown
Contributor Author

refack commented Mar 28, 2019

New CI for master - https://ci.nodejs.org/job/node-linter/3048/console
New CI for v8.x - https://ci.nodejs.org/job/node-linter/3049/console

@refack refack force-pushed the add-python-linting branch from 024d423 to 3369f2c Compare March 31, 2019 16:26
@refack
Copy link
Copy Markdown
Contributor Author

refack commented Apr 2, 2019

v6.x Linter: https://ci.nodejs.org/job/node-linter/3116/ ✔️
v6.x Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3146/ ✔️

@Trott
Copy link
Copy Markdown
Member

Trott commented Apr 2, 2019

/ping @nodejs/jenkins-admins to see if anyone else wants to take a look at this

@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented Apr 17, 2019 •
edited
Loading

This is linting on both Python 2 and 3?

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Apr 17, 2019

This is linting on both Python 2 and 3?

Yes for versions of Node.js > 11.

@sam-github
Copy link
Copy Markdown
Contributor

sam-github commented Jan 28, 2020

@richardlau do you understand enough to land this, or call it stale and close it?

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Jan 28, 2020 •
edited
Loading

These changes have already been made to the pipelines in question* so this PR is basically merging those changes to the backup jenkinsfile in this repository. We can have a separate discussion about whether having jenkinsfiles in SCM and not using those directly in the Jenkins jobs is a good idea or not but for now I'll just merge this in so the files here matches the scripts in the jobs.

* We haven't been running the node-test-pull-request-lite-pipeline job since we allowed just Travis CI for doc-only changes. I think there were reports over the Christmas period that it's possibly broken. Maybe we should just remove it? (Linting is done in node-test-pull-request/node-test-commit by a different lint job in Jenkins and we're also running the linters on Travis CI and GitHub Actions so it's not as if we're lacking coverage here.)

@richardlau richardlau merged commit b8d5cf2 into nodejs:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@Trott Trott Trott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@refack refack

Labels

ci-public enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can 'make lint-py PYTHON=python3' be a manditory Jenkins test?

5 participants

@refack @richardlau @Trott @cclauss @sam-github