Skip to content

doc: request token for amaro#933

Merged
marco-ippolito merged 1 commit intonodejs:mainfrom
marco-ippolito:request-token-for-amaro
Dec 29, 2024
Merged

doc: request token for amaro#933
marco-ippolito merged 1 commit intonodejs:mainfrom
marco-ippolito:request-token-for-amaro

Conversation

@marco-ippolito
Copy link
Copy Markdown
Member

@marco-ippolito marco-ippolito commented Nov 12, 2024

Should fix: nodejs/amaro#101

permissions:
  contents: write
  pull-requests: write

mhdawson
mhdawson approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the token name and date are filled in.

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Dec 2, 2024

@marco-ippolito could you name the token?

@marco-ippolito
Copy link
Copy Markdown
Member Author

marco-ippolito commented Dec 2, 2024

Does AMARO_SWC_UPDATE_TOKEN sound good?

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Dec 3, 2024

yeah, sounds good. TBH it's up to the owner of the repo.

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Dec 3, 2024

if it will be used in release-please as well, probably name it as like GH_USER_TOKEN.

@marco-ippolito marco-ippolito force-pushed the request-token-for-amaro branch from 5f72b12 to f3ab40d Compare December 10, 2024 14:13
@marco-ippolito marco-ippolito force-pushed the request-token-for-amaro branch from f3ab40d to 238939c Compare December 10, 2024 14:13
@marco-ippolito
Copy link
Copy Markdown
Member Author

marco-ippolito commented Dec 10, 2024

@legendecas I used same name as other ones since it will be used in release plz in the future, set expiration day as if it is created tomorrow. Can I create it myself?

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Dec 10, 2024 •
edited
Loading

if you have access to @nodejs-github-bot account please feel feel to go ahead. Or maybe @mhdawson could help with this

@marco-ippolito
Copy link
Copy Markdown
Member Author

marco-ippolito commented Dec 16, 2024 •
edited
Loading

@legendecas I apparently don't have access 😢

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Dec 16, 2024 •
edited
Loading

I don't have access either (mhdawson is on vacation). It'd be great to update this process with #936, which allow TSC members to grant new access without @nodejs-github-bot's password.

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Dec 24, 2024

Generated thet token and set in the amaro repository. @marco-ippolito can you check and land this PR if everything looks ok ?

@marco-ippolito
Copy link
Copy Markdown
Member Author

marco-ippolito commented Dec 26, 2024

the token does not have the right permission nodejs/amaro#101

@marco-ippolito
Copy link
Copy Markdown
Member Author

marco-ippolito commented Dec 29, 2024

It's working thanks!

@marco-ippolito marco-ippolito merged commit af9f9c1 into nodejs:main Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SWC update does not trigger CI

4 participants

@marco-ippolito @legendecas @mhdawson @jasnell