Update request-an-access-token.md#926
Merged
legendecas merged 8 commits intomainfrom Oct 29, 2024
Merged
Conversation
nschonni
reviewed
Oct 22, 2024
| --- | --- | --- | --- | | ||
| [`nodejs/import-in-the-middle`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2025-07-23 | <https://github.com/nodejs/admin/pull/902> | | ||
| [`nodejs/node-core-utils`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2025-09-01 | <https://github.com/nodejs/admin/pull/915> | | ||
| [`nodejs/wasm-builder`][] | `RELEASE_PLEASE_GITHUB_ACTION` | 2025-10-01 | <https://github.com/nodejs/admin/pull/926> | |
Member
There was a problem hiding this comment.
The reference [`nodejs/wasm-builder`] isn't defined at the bottom of the document
Member
Author
Member
There was a problem hiding this comment.
No problem.
PS, the diff would be smaller if this repo used the same ending of TOKEN instead of ACTION
Member
Author
There was a problem hiding this comment.
True, but that is a bigger change than just chaging in this repo. As I move over the repo I'll consider doing that.
Member
Author
|
@nodejs/tsc would be great to get an approval so that I can land this. |
legendecas
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requested token should have the following permissions: