Skip to content

Request a bot token for NCU#915

Merged
targos merged 2 commits intomainfrom
ncu-bot-token
Sep 1, 2024
Merged

Request a bot token for NCU#915
targos merged 2 commits intomainfrom
ncu-bot-token

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Aug 30, 2024

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write

https://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions

Fixes: #914

Comment thread request-an-access-token.md Outdated
@@ -45,6 +45,7 @@ permission scope changes. The PR should describe the permission scopes requested
Repo | Secret name | Expiration date | Pull Request |
--- | --- | --- | --- |
[`nodejs/import-in-the-middle`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2025-07-23 | <https://github.com/nodejs/admin/pull/902> |
Copy link
Copy Markdown
Member

@targos targos Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I renamed this secret to RELEASE_PLEASE_GITHUB_TOKEN - iitm (in the bot's settings, not in the repo) to make it recognizable. I didn't know about this registry.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth documenting what string to use on the bot's settings side (e.g. <name of the repo>: <Secret name>)

Copy link
Copy Markdown
Member

@nschonni nschonni Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, there are others like https://github.com/nodejs/remark-preset-lint-node that probably need a similar token, but probably shouldn't be the same one I guess this is just the repo Secret Name, so maybe there isn't a collision

@joyeecheung
Copy link
Copy Markdown
Member

joyeecheung commented Aug 30, 2024

By the way I think simply reusing the GITHUB_TOKEN can solve most permission issues? The permission of that token is defined directly in the workflow files, see https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#permissions so there won't be a need to request for a new token if it's used.

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Aug 30, 2024

@joyeecheung using the GITHUB_TOKEN would result in tests not being triggered without closing and reopening the PR, which is not ideal – hence this request.

@joyeecheung
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos merged commit d6fe2ac into main Sep 1, 2024
@targos targos deleted the ncu-bot-token branch September 1, 2024 10:43
@StefanXhunga
Copy link
Copy Markdown

Hello everyone, thank you for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow nodejs-github-bot to release node-core-utils

6 participants