Skip to content

doc: import-in-the-middle release token#902

Merged
legendecas merged 3 commits intonodejs:mainfrom
legendecas:expiration
Jul 30, 2024
Merged

doc: import-in-the-middle release token#902
legendecas merged 3 commits intonodejs:mainfrom
legendecas:expiration

Conversation

@legendecas
Copy link
Copy Markdown
Member

@legendecas legendecas commented Jul 23, 2024

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write

https://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions

/cc @mhdawson the repo has already a token configured with my personal token. please feel free to replace it with @nodejs-github-bot's one.

@legendecas legendecas force-pushed the expiration branch 2 times, most recently from c480f80 to 56a37ca Compare July 23, 2024 20:08
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread request-an-access-token.md Outdated
@mhdawson
Copy link
Copy Markdown
Member

Created the token as the original request was already approved and added to the repo.

Comment thread request-an-access-token.md Outdated
@legendecas
Copy link
Copy Markdown
Member Author

Added a missing step found in nodejs/import-in-the-middle#150 to grant @nodejs-github-bot write access on the repo if necessary.

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit 0acfbba into nodejs:main Jul 30, 2024
@legendecas legendecas deleted the expiration branch July 30, 2024 14:02
@legendecas legendecas mentioned this pull request Aug 4, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants